Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keymap] Update audio controls on community #8163

Merged
merged 3 commits into from
Feb 14, 2020
Merged

[keymap] Update audio controls on community #8163

merged 3 commits into from
Feb 14, 2020

Conversation

yanfali
Copy link
Contributor

@yanfali yanfali commented Feb 13, 2020

Update community layout keymaps

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yanfali yanfali added the keymap label Feb 13, 2020
@yanfali yanfali requested a review from a team February 13, 2020 21:37
@zvecr zvecr requested a review from a team February 13, 2020 21:58
ridingqwerty
ridingqwerty approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@ridingqwerty ridingqwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big brane time

@yanfali
Copy link
Contributor Author

yanfali commented Feb 13, 2020

let me add tkl support then I'll square this away

@yanfali yanfali merged commit eb1f99c into qmk:master Feb 14, 2020
@yanfali yanfali deleted the yanfali-community-update branch February 14, 2020 19:03
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@yanfali @HokieGeek
[keymap] Update audio controls on community (qmk#8163)
5622359 
* Update audio controls on community

* Add rules for various boards

* TKL support
c0psrul3 pushed a commit to c0psrul3/qmk_firmware that referenced this pull request Mar 23, 2020
@yanfali @c0psrul3
[keymap] Update audio controls on community (qmk#8163)
40d11f9 
* Update audio controls on community

* Add rules for various boards

* TKL support
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
@yanfali @kujawakk
[keymap] Update audio controls on community (qmk#8163)
e8edc39 
* Update audio controls on community

* Add rules for various boards

* TKL support
jakeisnt pushed a commit to jakeisnt/qmk_firmware that referenced this pull request Aug 20, 2020
@yanfali @jakeisnt
[keymap] Update audio controls on community (qmk#8163)
5a06942 
* Update audio controls on community

* Add rules for various boards

* TKL support
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@yanfali
[keymap] Update audio controls on community (qmk#8163)
0161c1e 
* Update audio controls on community

* Add rules for various boards

* TKL support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanfali @ridingqwerty @zvecr