Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] Plain60 cleanups #7644

Merged
merged 5 commits into from
Dec 15, 2019
Merged

Conversation

yanfali
Copy link
Contributor

@yanfali yanfali commented Dec 15, 2019

Discord user typischt requested access to bootmagic and a reset coed on default keymap.

Description

  • enable bootmagic lite to make resetting easier
  • add a RESET keycode to default keymap on a layer
    • override KC_UP and KC_APP to be MO(1)
  • remove obsolete comments about sizes from rules.mk

This seem ok @Maartenwut ?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Yan-Fa Li added 3 commits December 15, 2019 07:52
 - it's easier to reset and maintain a keyboard with lite
 - remove obsolete size comments
@zvecr zvecr merged commit 3eb82e0 into qmk:master Dec 15, 2019
benjaminmikiten added a commit to benjaminmikiten/qmk_firmware that referenced this pull request Dec 18, 2019
* master: (99 commits)
  [Keymap] Added userspace for d4mation. Included their keymap for the Atreus62 (qmk#7483)
  [Keymap] Custom user keymap for Think6.5 with LED range control (qmk#7603)
  [Keymap] CRKBD Custom Keymap - KidBrazil (qmk#7630)
  [Keymap] Add pico 70 keys keymap (qmk#7654)
  Tidy up dztech default keymaps and info.json (qmk#7608)
  Heisenberg handwired keyboard added (qmk#7643)
  [Keyboard] Added Filco Majestouch TKL Pegasus Hoof ISO Layout (qmk#7647)
  Ported J80 to QMK (qmk#7488)
  [Keyboard] Magnavox Videowriter conversion with Pro Micro (qmk#7634)
  [Docs] add japanese translation (basic part) (qmk#7461)
  Tidy up dztech rules.mk
  Relocate RGB keycode processing (qmk#7508)
  Move kwerdenker's personal keymap from RGB (qmk#7645)
  Remove QMK_KEYBOARD_CONFIG_H from boards (qmk#7635)
  Disable usb on slave half to resolve random 'lockup' (qmk#7649)
  [Core] Optimize matrix processing (qmk#7621)
  [Keymap] boy_314's satisfaction75 layout (qmk#7638)
  [Keyboard] XD68 65% ATMega32U4 based (qmk#7395)
  [keyboard] Plain60 cleanups (qmk#7644)
  update default h88 keymap (qmk#7646)
  ...
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
* Change plain60 to bootmagic lite

 - it's easier to reset and maintain a keyboard with lite
 - remove obsolete size comments

* Add RESET on a layer to default keymap

* Use _FN

* Maintain compatibility with keymap

* Fix thinko
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* Change plain60 to bootmagic lite

 - it's easier to reset and maintain a keyboard with lite
 - remove obsolete size comments

* Add RESET on a layer to default keymap

* Use _FN

* Maintain compatibility with keymap

* Fix thinko
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants