Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install bootloadHid as part of qmk_install #7463

Merged
merged 6 commits into from
Nov 28, 2019
Merged

Install bootloadHid as part of qmk_install #7463

merged 6 commits into from
Nov 28, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 24, 2019 •
edited
Loading

Description

Many previous PRs have started to flesh out the bootloadHID integration.

This PR installs on a bunch of platforms to make :flash work as much as possible.

  • windows
  • macos
  • linux
    • kinda a messy install for all supported distros
    • errors out "gracefully" if dependencies are not available

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the core label Nov 24, 2019
@zvecr zvecr changed the title [WIP] Install bootloadHid as part of qmk_install Install bootloadHid as part of qmk_install Nov 24, 2019
@zvecr zvecr requested a review from a team November 24, 2019 19:59
@zvecr zvecr marked this pull request as ready for review November 24, 2019 19:59
drashna
drashna approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@drashna drashna requested a review from a team November 25, 2019 20:39
@zvecr zvecr requested a review from fauxpark November 27, 2019 23:52
@zvecr zvecr merged commit 235da69 into qmk:master Nov 28, 2019
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
@zvecr
Install bootloadHid as part of qmk_install (qmk#7463)
17d1751 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Dec 10, 2019
@zvecr @drashna
Install bootloadHid as part of qmk_install (qmk#7463)
00761cd 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
@drashna drashna mentioned this pull request Dec 10, 2019
Merged
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Dec 10, 2019
@zvecr @drashna
Install bootloadHid as part of qmk_install (qmk#7463)
f8a7d64 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
@zvecr @patrl
Install bootloadHid as part of qmk_install (qmk#7463)
b199e26 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 6, 2020
@zvecr @fdidron
Install bootloadHid as part of qmk_install (qmk#7463)
0ee2b2e 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
fdidron pushed a commit to zsa/qmk_firmware that referenced this pull request Jan 8, 2020
@zvecr @fdidron
Install bootloadHid as part of qmk_install (qmk#7463)
50fcd78 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
@zvecr @HokieGeek
Install bootloadHid as part of qmk_install (qmk#7463)
d74d14f 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
@zvecr zvecr deleted the feature/install_bootloadHID branch April 28, 2020 01:03
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@zvecr
Install bootloadHid as part of qmk_install (qmk#7463)
20e1be1 
* Install bootloadHid on macos

* Install bootloadHid on windows

* Highlight bootloadHID is now installed in docs

* Update udev rules for bootloadHID

* Install bootloadHid on some distros

* fix caterina udev filename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark