Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the layer state messages for actual values #6116

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Fix the layer state messages for actual values #6116

merged 1 commit into from
Jun 11, 2019

Conversation

yanfali
Copy link
Contributor

@yanfali yanfali commented Jun 11, 2019

  • display adjust when the bits are set correctly

The current definitions just make the UI display undefined 8 and undefined 14, instead of Adjust.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@yanfali
Fix the layer state messages for actual values
76db198 
 - display adjust when the bits are set correctly
drashna
drashna approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked. Yeah, this is the correct value.

@drashna drashna merged commit d0c29f2 into qmk:master Jun 11, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@yanfali @Timbus
[Keyboard] Fix the layer state messages for actual values (qmk#6116)
8ab5c9a 
- display adjust when the bits are set correctly
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
@yanfali @doughsay
[Keyboard] Fix the layer state messages for actual values (qmk#6116)
1a7215b 
- display adjust when the bits are set correctly
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@yanfali @drashna
[Keyboard] Fix the layer state messages for actual values (qmk#6116)
bb9e857 
- display adjust when the bits are set correctly
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@yanfali @JeffreyPalmer
[Keyboard] Fix the layer state messages for actual values (qmk#6116)
a9264d7 
- display adjust when the bits are set correctly
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@yanfali @swamp09
[Keyboard] Fix the layer state messages for actual values (qmk#6116)
9eaeb0d 
- display adjust when the bits are set correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanfali @drashna