Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Commissions to repo 1 #5995

Merged
merged 4 commits into from
May 28, 2019
Merged

Merge Commissions to repo 1 #5995

merged 4 commits into from
May 28, 2019

Conversation

e11i0t23
Copy link
Contributor

Description

Added support of 3 boards which have been tested and manufactured in the past year but needed adding to qmk repo. all boards are added to ep/comsn/**

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft
noroadsleft requested changes May 27, 2019
View reviewed changes
keyboards/ep/comsn/hs68/config.h Outdated Show resolved Hide resolved
keyboards/ep/comsn/hs68/hs68.h Outdated Show resolved Hide resolved
keyboards/ep/comsn/hs68/hs68.h Outdated Show resolved Hide resolved
keyboards/ep/comsn/hs68/hs68.h Outdated Show resolved Hide resolved
keyboards/ep/comsn/hs68/info.json Show resolved Hide resolved
keyboards/ep/comsn/tf_longeboye/rules.mk Outdated Show resolved Hide resolved
keyboards/ep/comsn/tf_longeboye/rules.mk Outdated Show resolved Hide resolved
keyboards/ep/comsn/tf_longeboye/tf_longeboye.h Outdated Show resolved Hide resolved
keyboards/ep/comsn/tf_longeboye/tf_longeboye.h Outdated Show resolved Hide resolved
keyboards/ep/comsn/tf_longeboye/tf_longeboye.h Outdated Show resolved Hide resolved
@e11i0t23 @noroadsleft
Update keyboards/ep/comsn/hs68/config.h
136f265 
Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>
noroadsleft
noroadsleft approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@drashna drashna requested review from drashna, mechmerlin and yanfali May 28, 2019 18:33
@drashna drashna merged commit a31c2ac into qmk:master May 28, 2019
CountBacula pushed a commit to CountBacula/qmk_firmware that referenced this pull request May 28, 2019
@e11i0t23 @CountBacula
[Keyboard] Merge Commissions to repo (qmk#5995)
fe74f76 
* Moved commisions to one folder

* Update keyboards/ep/comsn/hs68/config.h

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

* Resolve merge issues

* Fix comiplation issues
@e11i0t23 e11i0t23 deleted the comisions branch May 31, 2019 19:24
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@e11i0t23 @Timbus
[Keyboard] Merge Commissions to repo (qmk#5995)
87ae48b 
* Moved commisions to one folder

* Update keyboards/ep/comsn/hs68/config.h

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

* Resolve merge issues

* Fix comiplation issues
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@e11i0t23 @drashna
[Keyboard] Merge Commissions to repo (qmk#5995)
eaf453a 
* Moved commisions to one folder

* Update keyboards/ep/comsn/hs68/config.h

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

* Resolve merge issues

* Fix comiplation issues
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@e11i0t23 @JeffreyPalmer
[Keyboard] Merge Commissions to repo (qmk#5995)
31aeb9f 
* Moved commisions to one folder

* Update keyboards/ep/comsn/hs68/config.h

Co-Authored-By: noroadsleft <18669334+noroadsleft@users.noreply.github.com>

* Resolve merge issues

* Fix comiplation issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@yanfali yanfali Awaiting requested review from yanfali

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e11i0t23 @drashna @fauxpark @noroadsleft