Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTTPS for qmk.fm link #5506

Merged
merged 2 commits into from
May 1, 2019
Merged

Use HTTPS for qmk.fm link #5506

merged 2 commits into from
May 1, 2019

Conversation

fauxpark
Copy link
Member

Description

🤷‍♂️

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Mar 29, 2019

Doesn't the HTTP site automatically redirect to the HTTPS site?

@noroadsleft
Copy link
Member

@drashna It does.

yanfali
yanfali approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good practice anyway, for privacy reasons.

@fauxpark
Copy link
Member Author

Slightly expanded the scope of this PR to include the rest of the links in the file that were HTTP.

@drashna drashna merged commit e4b5c44 into qmk:master May 1, 2019
@fauxpark fauxpark deleted the readme-qmk-fm-https branch May 1, 2019 04:55
foosinn pushed a commit to foosinn/qmk_firmware that referenced this pull request May 6, 2019
@fauxpark @foosinn
[Docs] Use HTTPS for qmk.fm link (qmk#5506)
08d974d 
* Use HTTPS for qmk.fm link

* Fix the rest of the HTTP links
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@fauxpark @Timbus
[Docs] Use HTTPS for qmk.fm link (qmk#5506)
fc5c3a9 
* Use HTTPS for qmk.fm link

* Fix the rest of the HTTP links
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@fauxpark @drashna
[Docs] Use HTTPS for qmk.fm link (qmk#5506)
cf41397 
* Use HTTPS for qmk.fm link

* Fix the rest of the HTTP links
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@fauxpark @JeffreyPalmer
[Docs] Use HTTPS for qmk.fm link (qmk#5506)
194076e 
* Use HTTPS for qmk.fm link

* Fix the rest of the HTTP links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanfali yanfali yanfali approved these changes

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

@ezuk ezuk Awaiting requested review from ezuk

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fauxpark @drashna @noroadsleft @yanfali