Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate fn_actions for default keymaps #4935

Merged
merged 9 commits into from
Feb 15, 2019
Merged

Migrate fn_actions for default keymaps #4935

merged 9 commits into from
Feb 15, 2019

Conversation

fauxpark
Copy link
Member

Description

Going through the default keymaps and changing the fn_actions entries to either keycodes or their process_record_user() equivalents.

Types of changes

  • Core
  • Bugfix
  • New Feature
  • Enhancement/Optimization
  • Keyboard (addition or update)
  • Keymap/Layout/Userspace (addition or update)
  • Documentation

Issues Fixed or Closed by this PR

  • None

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

vomindoraan
vomindoraan suggested changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@vomindoraan vomindoraan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and so on. The get_mods() & MODS_SHIFT_MASK and removing shift_esc_shift_mask changes apply to a lot of the keymaps.

That said, keep up the good work. We've had a lot of nice cleanup PRs over these past few weeks.

keyboards/satan/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satan/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satan/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satan/keymaps/poker/keymap.c Outdated Show resolved Hide resolved
keyboards/satan/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/satan/keymaps/colemak/keymap.c Outdated Show resolved Hide resolved
keyboards/mechmini/v2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/kona_classic/keymaps/iso_split_arrows/keymap.c Outdated Show resolved Hide resolved
@fauxpark
Copy link
Member Author

Thanks for the reviews @vomindoraan 👍

mechmerlin
mechmerlin approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=)

@mechmerlin mechmerlin merged commit 9e4ac6c into qmk:master Feb 15, 2019
@fauxpark fauxpark deleted the migrate-default-keymaps-fn-actions branch February 15, 2019 04:08
dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
@fauxpark
Migrate fn_actions for default keymaps (qmk#4935)
d950d8e 
* Migrate fn_actions for default keymaps

* Rename the Grave/Escape Shift masks

* No need for shift_esc_shift_mask

* Change breaks to return false

* Right align pointers

* Add default case

* Separate cases with empty lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vomindoraan vomindoraan vomindoraan requested changes

@pelrun pelrun pelrun left review comments

@mechmerlin mechmerlin mechmerlin approved these changes

@drashna drashna drashna approved these changes

@skullydazed skullydazed Awaiting requested review from skullydazed

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@jackhumbert jackhumbert Awaiting requested review from jackhumbert

Assignees
No one assigned
Labels
keymap optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fauxpark @pelrun @vomindoraan @drashna @mechmerlin