Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chibios_test/stm32_f072_onekey: Add support for reset to bootloader #4238

Merged
merged 2 commits into from
Dec 25, 2018
Merged

Chibios_test/stm32_f072_onekey: Add support for reset to bootloader #4238

merged 2 commits into from
Dec 25, 2018

Conversation

TerryMathews
Copy link
Contributor

Chibios_test/stm32_f072_onekey wouldn't reset to bootloader on a
compatible Discovery board because the Chibios library board file was
lacking the __early_init(void) function necessary to read the magic key.
Borrowed code from Clueboard 60, tested working.

This way there will be good example code if anyone else implements an 072 MCU in their project.

@TerryMathews
Add support for reset to bootloader
ff4c9d2 
Chibios_test/STM32_F072_ONEKEY wouldn't reset to bootloader on a
compatible Discovery board because the Chibios library board file was
lacking the __early_init(void) function necessary to read the magic key.
Borrowed code from Clueboard 60, tested working.
@yiancar
Copy link
Contributor

yiancar commented Oct 26, 2018

I think cfg/board.chcfg is not needed. Am I right?:)

@TerryMathews
Copy link
Contributor Author

TerryMathews commented Nov 25, 2018 •
edited
Loading

@yiancar I do believe you are correct, compiles with it removed.

Can this be approved now that I've cleaned it up?

@TerryMathews
Copy link
Contributor Author

@jackhumbert Can you review and approve please?

@TerryMathews
Copy link
Contributor Author

Can someone please approve this?

@TerryMathews
Copy link
Contributor Author

@drashna now can I get a merge?

@drashna drashna requested a review from mechmerlin December 4, 2018 05:21
@TerryMathews
Copy link
Contributor Author

I don't know what the holdup is on this PR, but I have other things to work on. I'm going to have to catch up my repo and start working by 12/27.

I hate to be difficult about it, but it's been two months.

@drashna
Copy link
Member

drashna commented Dec 25, 2018

Actually, I was just thinking about this the other day.

Thanks!

@drashna drashna merged commit de78d9e into qmk:master Dec 25, 2018
WarmCatUK added a commit to WarmCatUK/qmk_firmware that referenced this pull request Dec 26, 2018
@WarmCatUK
Creating tigerlily layout
21aaada 
Merge branch 'master' into messingabout

* master: (131 commits)
  Improve diagnostics for build hashes
  XMMX refactor, Configurator support and readme update (qmk#4722)
  Chibios_test/stm32_f072_onekey: Add support for reset to bootloader (qmk#4238)
  Add tsangan layout to dz60 with a "sane" default keymap (qmk#4717)
  Redox: Configurator bugfix (qmk#4721)
  Replace serial.c of quantum/split_common/ (qmk#4669)
  Toad Configurator support and readme update (qmk#4718)
  Keymap: fix userspace compile error with planck grid (qmk#4719)
  First PR for KBD6x HHKB layout keymap (qmk#4704)
  [Miuni32] Update the # of LEDs to match the final version of PCB (qmk#4714)
  Noxary x268: refactor and Configurator bugfix (qmk#4713)
  shell.nix: Packages relocated in upstream cleanup
  JD40 refactor and readme update (qmk#4710)
  Keyboard: Infinity60 refactor, Configurator support and readme update (qmk#4707)
  Update Vinta (qmk#4705)
  Add crd's XD60 ANSI keymap (qmk#4702)
  Keymap: Redox / jeherve: updates (qmk#4694)
  Update keymap for planck/rev6 (qmk#4701)
  handwired/not_so_minidox: Configurator support (qmk#4699)
  Feature Unicode example code fixed.
  ...
yeliu84 pushed a commit to yeliu84/qmk_firmware that referenced this pull request Jan 7, 2019
@TerryMathews @yeliu84
Chibios_test/stm32_f072_onekey: Add support for reset to bootloader (q…
d966116 
…mk#4238)

* Add support for reset to bootloader

Chibios_test/STM32_F072_ONEKEY wouldn't reset to bootloader on a
compatible Discovery board because the Chibios library board file was
lacking the __early_init(void) function necessary to read the magic key.
Borrowed code from Clueboard 60, tested working.

* Remove board.chcfg
rseymour pushed a commit to rseymour/qmk_firmware that referenced this pull request Mar 13, 2019
@TerryMathews @rseymour
Chibios_test/stm32_f072_onekey: Add support for reset to bootloader (q…
6647c88 
…mk#4238)

* Add support for reset to bootloader

Chibios_test/STM32_F072_ONEKEY wouldn't reset to bootloader on a
compatible Discovery board because the Chibios library board file was
lacking the __early_init(void) function necessary to read the magic key.
Borrowed code from Clueboard 60, tested working.

* Remove board.chcfg
djthread pushed a commit to djthread/qmk_firmware that referenced this pull request Mar 17, 2019
@TerryMathews @djthread
Chibios_test/stm32_f072_onekey: Add support for reset to bootloader (q…
63a097d 
…mk#4238)

* Add support for reset to bootloader

Chibios_test/STM32_F072_ONEKEY wouldn't reset to bootloader on a
compatible Discovery board because the Chibios library board file was
lacking the __early_init(void) function necessary to read the magic key.
Borrowed code from Clueboard 60, tested working.

* Remove board.chcfg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackhumbert jackhumbert jackhumbert approved these changes

@drashna drashna drashna approved these changes

@fredizzimo fredizzimo Awaiting requested review from fredizzimo

@skullydazed skullydazed Awaiting requested review from skullydazed

@mechmerlin mechmerlin Awaiting requested review from mechmerlin

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TerryMathews @yiancar @drashna @jackhumbert