keyboards/annepro2/ld: Add per-variant linker scripts #24999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C18 has an MCU with 16K SRAM, up from C15's 8K. Split the linker script into C15 and C18 variants to make use of the larger RAM capacity of C18. Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
|
Not sure what to do about the missing copyright headers, as I don't know the original authors, and I haven't touched those files at all |
|
You can ignore those lint errors, as they were not introduced by this PR. |
drashna
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C18 has an MCU with 16K SRAM, up from C15's 8K.
Split the linker script into C15 and C18 variants to make use of the larger RAM capacity of C18.
Description
Anne Pro 2 has two variants, C15 and C18. C15's MCU has 8K SRAM, C18's has 16K.
To enable VIA on the C18 variant, the RAM size must be increased.
I was not able to test C15, only the C18 variant. I've only checked that the C15 variant compiles and uses the correct linker script (which is unchanged).
Types of Changes
Issues Fixed or Closed by This PR
Checklist