Add Harite v2 keyboard #24975
Add Harite v2 keyboard #24975
Conversation
There was a problem hiding this comment.
The default keymap should be kept simple.
The extra code should be moved to a vendor keymap, or to the keyboard's code (eg, a haritev2.c file).
There was a problem hiding this comment.
The options in this file probably should be moved to the keyboard level, as they are not keymap-specific.
There was a problem hiding this comment.
@waffle87 This board has another configuration that uses a trackball on one side, if they are moved to the keyboard level, would I make a different keyboard for each one or is there another option?
| POINTING_DEVICE_ENABLE = yes | ||
| POINTING_DEVICE_DRIVER = cirque_pinnacle_spi | ||
| SPI_DRIVER_REQUIRED = yes | ||
|
|
There was a problem hiding this comment.
As above — this moved to the keyboard level. And this file removed.
| POINTING_DEVICE_ENABLE = yes | |
| POINTING_DEVICE_DRIVER = cirque_pinnacle_spi | |
| SPI_DRIVER_REQUIRED = yes |
keyboards/haritev2/rules.mk
Outdated
There was a problem hiding this comment.
These options need to migrated to keyboard.json and this file removed.
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Co-authored-by: jack <jack@pngu.org>
Description
Add Harite v2 keyboard
Types of Changes
Checklist