Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sofle rgb_default keymap #24971

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Mar 1, 2025

Description

Looks more like a user keymap, LED configuration is mismatched vs the Sofle RGB defining 70 total rather than the correct 72.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the keymap label Mar 1, 2025
@daskygit daskygit marked this pull request as draft March 2, 2025 00:30
@daskygit
Copy link
Member Author

daskygit commented Mar 2, 2025

Thanks for the reviews, no merging yet though need to clarify/work out if I really want to be touching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants