Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Keyboard LumPy27 #24967

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Added Keyboard LumPy27 #24967

wants to merge 10 commits into from

Conversation

djreisch
Copy link

@djreisch djreisch commented Mar 1, 2025

Description

Added the configurations for the LumPy27, an RP2040 powered keyboard I developed.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json -i keyboards/djreisch/lumpy27/keyboard.json on this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran it. Will be in next commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace the tabs in this file with spaces. You can use qmk format-c, although you will need to re-format the keymap.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file. Encoders are not present on this keyboard.

@djreisch djreisch requested a review from waffle87 March 2, 2025 07:39
Co-authored-by: Drashna Jaelre <drashna@live.com>
@djreisch djreisch requested a review from drashna March 3, 2025 05:13

A: For certain games I found it easier instead of remapping them to just change where they are. That's why keys like B and G are not in the right spots.

* Keyboard Maintainer: [djreisch](https://github.com/djreisch)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please readd the hardware availability part. Even if this is just a github repo or whatnot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants