Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new macropad Sharkropad #24961

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add new macropad Sharkropad #24961

wants to merge 4 commits into from

Conversation

mawaeg
Copy link

@mawaeg mawaeg commented Feb 27, 2025

Description

This PR adds a new macropad, Sharkropad, to the repository.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).


#ifdef OLED_ENABLE

const char *rgb_matrix_effect_names[] = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this code should go into a sharkropad.c file instead, as the default keymap should be kept pristine.

Also, this effect list isn't .... exactly accurate. If effects are enabled/disabled, this list will drift. You may want something like this instead:
https://github.com/drashna/qmk_userspace/blob/65874ada48ff35d177c7a3cd10f2a6d5b9580e0c/users/drashna/rgb/rgb_matrix_stuff.c#L248-L307

This generates the list based on the enabled effects at compile time, and formats the strings to be a bit more pleasant. (it also keeps the last mode and associated string to skip the string generation if the mode hasn't changed).

## Bootloader

Enter the bootloader:
* **Bootmagic reset**: Hold down the rotary encoder knob and plug in the keyboard
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No physical reset button on the pcb?

@drashna drashna requested a review from a team February 28, 2025 19:18
@mawaeg mawaeg marked this pull request as draft March 1, 2025 15:47
Co-authored-by: Drashna Jaelre <drashna@live.com>
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove executable file permission from these files:

.rw-r--r-- 809B jack 01 Mar 2025 12:56  config.h
.rwxr-xr-x 746B jack 01 Mar 2025 12:56  halconf.h
.rwxr-xr-x 4.7K jack 01 Mar 2025 12:56  keyboard.json
drwxr-xr-x 4.0K jack 01 Mar 2025 12:56  keymaps
.rwxr-xr-x 779B jack 01 Mar 2025 12:56  mcuconf.h
.rwxr-xr-x 931B jack 01 Mar 2025 12:56  readme.md

keymaps/default:
.rwxr-xr-x 3.3K jack 01 Mar 2025 12:56  keymap.c
.rwxr-xr-x  25B jack 01 Mar 2025 12:56  rules.mk

mawaeg and others added 2 commits March 2, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants