Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Would you like to clone the submodules?' prompt under msys #24958

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 26, 2025

Description

When running qmk setup on msys, with missing submodules, the "Would you like to clone the submodules? [Y/n]" prompt refuses to accept any input.

Questions asked before the check_binary_versions call work, anything afterwards, broken.

From https://github.com/clueboard/milc/blob/master/milc/milc.py#L170-L173

        # On some windows platforms (msys2, possibly others) you have to
        # execute the command through a subshell. As well, after execution
        # stdin is broken so things like milc.questions no longer work.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Feb 26, 2025
@zvecr zvecr added the bug label Feb 26, 2025
@zvecr zvecr marked this pull request as ready for review February 26, 2025 23:12
@zvecr zvecr changed the base branch from develop to master February 27, 2025 22:32
@drashna drashna requested a review from a team February 28, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant