Add FE87 TKL PCB

[mrnoisytiger]

Description

Add FE87 TKL PCB.

Types of Changes

• Core
• Bugfix
• New feature
• Enhancement/optimization
• Keyboard (addition or update)
• Keymap/layout (addition or update)
• Documentation

Checklist

• My code follows the code style of this project: C, Python
• I have read the PR Checklist document and have made the appropriate changes.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[mrnoisytiger]

Thanks for the review!

[dunk2k]

Presuming image in Instagram post is accurate, then this PCB supports community layouts:

• tkl_ansi
• tkl_ansi_split_bs_rshift
• tkl_iso
• tkl_iso_split_bs_rshift
• tkl_ansi_tsangan
• tkl_ansi_tsangan_split_bs_rshift
• tkl_iso_tsangan
• tkl_iso_tsangan_split_bs_rshift

[mrnoisytiger]

@dunk2k Yep, they have been added. And also added WKL versions because PCB is intended to be compatible with odd keyboards with removeable blockers.

Thanks! Seems like the lint failed though if I add in the community layouts array to the keyboard.json.

[zvecr]

From lint

linting fjlabs/fe87
⚠ fjlabs/fe87: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

In this case, renaming it to LAYOUT would not be accepted, and additional layouts must be provided.

[mrnoisytiger]

@zvecr Mind helping me better understand what the ask is?

Are you asking to include all the community layouts in the keymap.c and keyboard.json files instead? Is there a minimum subset that would be acceptable and leaving the rest as an exercise to the user?

Duplicating the base keymap over 10 times to account for WKL/WK split/non-split 6.25U/7U ISO/non-ISO seems to be a bit much in terms of file size management, but I defer to you as a maintainer what the preference is here and I’ll
maintain that approach going forward.