Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keymap] Sofle RGB - fixed stuck on numpad layer and layout comments (#24941) #24942

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matheusmbar
Copy link

Description

Fixed bug of getting stuck on Numpad layer (#24941)

  • Set key on Adjust layer as transparent to allow detection of key depress when activating Numpad layer using LT(_SWITCH,KC_6) and TO(6)

  • Add F12 key to LOWER layer, it was not present anywer in the keymap

  • Fix mismatched keymap documentations

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Set key on Adjust layer as transparent to allow detection of key
depress when activating Numpad layer using `LT(_SWITCH,KC_6)` and `TO(6)`

Add F12 key to LOWER layer, it was not present anywer in the keymap

Fix mismatched keymap documentations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant