Add str_studio cadence_16 keyboard #24940
Conversation
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
|
|
||
| // ================== OLED ================== | ||
|
|
||
| #ifdef OLED_ENABLE |
There was a problem hiding this comment.
All this code should be moved to the keyboard level in a cadence_16.c file, since it looks like OLEDs are intended to be installed on this keyboard.
There was a problem hiding this comment.
Hello @waffle87 thank you so much for taking the time to review this!
I attempted to implement your suggestion by moving the OLED code from the keymap file to cadence_16.c at the keyboard level. However, I encountered compilation errors during testing, could you please help me identify what I might have missed here?
I referenced other keyboards that use the default keymap structure, but I want to ensure I follow QMK conventions correctly. Any guidance or examples would be greatly appreciated!
There was a problem hiding this comment.
if the candence_16.c doesn't have an #include "quantum.h" or #include QMK_KEYBOARD_H, it may be missing a bunch of these includes.
| {"matrix": [0, 3], "x": 3, "y": 0}, | ||
| {"matrix": [1, 0], "x": 0, "y": 1}, | ||
| {"matrix": [1, 1], "x": 1, "y": 1}, | ||
| {"matrix": [1, 2], "x": 2, "y": 1}, | ||
| {"matrix": [1, 3], "x": 3, "y": 1}, | ||
| {"matrix": [2, 0], "x": 0, "y": 2}, | ||
| {"matrix": [2, 1], "x": 1, "y": 2}, | ||
| {"matrix": [2, 2], "x": 2, "y": 2}, | ||
| {"matrix": [2, 3], "x": 3, "y": 2}, | ||
| {"matrix": [3, 0], "x": 0, "y": 3}, | ||
| {"matrix": [3, 1], "x": 1, "y": 3}, | ||
| {"matrix": [3, 2], "x": 2, "y": 3}, | ||
| {"matrix": [3, 3], "x": 3, "y": 3, "h": 1.5}, | ||
| {"matrix": [4, 0], "x": 0, "y": 4}, | ||
| {"matrix": [4, 1], "x": 1, "y": 4}, | ||
| {"matrix": [4, 2], "x": 2, "y": 4} |
There was a problem hiding this comment.
These coordinates do not appear to match this keyboard's physical layout:
There was a problem hiding this comment.
Hi @waffle87, thank you for flagging this! I based the coordinate mapping on my physical PCB layout and verified the key positions during testing
However, I’d be happy to adjust this if there’s a mismatch with QMK’s expected standards. Could you please share more details about the discrepancy you observed? I want to ensure this aligns perfectly with both the hardware and firmware expectations.
There was a problem hiding this comment.
The issue is the bottom right key's size. In your keyboard.json file, it is only 1.5u tall. Physically, it is 2u tall.
Co-authored-by: jack <jack@pngu.org>
Description
Add str_studio cadence_16 keyboard
Types of Changes
Issues Fixed or Closed by This PR
Checklist