Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new keyboard - Slothie60 #24931

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

makkomise
Copy link

Description

QMK-support for my passion project, Slothie60!. Added keymap and json-file.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • [x ] Keyboard (addition or update)
  • [x ] Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • [ x] My code follows the code style of this project: C, Python
  • [ x] I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Committing suggested changes to files
@makkomise
Copy link
Author

Thank you so much for the suggestions! They all should be fixed now. IDK why the CI build shows failed, even though it does compile atleast on my end

@sigprof
Copy link
Contributor

sigprof commented Feb 19, 2025

Your definition of LAYOUT_60_iso does not match the 60_iso community layout, therefore building the default_60_iso keymap fails.

Apparently your PCB supports multiple layout options, so you need to provide several layout definitions (including LAYOUT_60_iso, if it's possible to build that exact layout with your PCB, otherwise you should use a different name and remove community_layouts).

@makkomise
Copy link
Author

Screenshot 2025-02-19 131900

I've updated the layouts and it gives me these errors in msys now, even though it does still compile. I've tried looking at documentation and google, but i didn't get certain answer on why these errors happen. Is this something that's okay or could you give me any help on what to do?

@sigprof
Copy link
Contributor

sigprof commented Feb 19, 2025

You need to provide the matrix positions ("matrix": [0, 0] and the like) in all layouts, not just LAYOUT_all (QMK can't deduce that info from another layout).

@makkomise
Copy link
Author

You need to provide the matrix positions ("matrix": [0, 0] and the like) in all layouts, not just LAYOUT_all (QMK can't deduce that info from another layout).

But i do have those in the keyboard.json. Do they also need to be provided elsewhere?

- Added missing matrix information to keyboard.json
- Added one more layout because i didn't even realise that combination was also a thing you could do lol.
- i am dumb
- both
- Updated the json as per suggestions
- Ran qmk-format-json
- Removed unnecessary files
@makkomise makkomise requested review from zvecr and sigprof February 19, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants