Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keychron C3 Pro (Red & RGB) #24874

Merged
merged 12 commits into from
Jan 29, 2025
Merged

Add Keychron C3 Pro (Red & RGB) #24874

merged 12 commits into from
Jan 29, 2025

Conversation

adophoxia
Copy link
Contributor

Description

As title. This PR is a spin-off to #21860 as it's updated to current QMK standards as the previous PR wasn't. This also adds the RGB variant of the board from playground that's been stripped of any "Keychron" aka, factory code to be compatible with upstream. Done my best to be as in line as possible while also retaining its original features like KC_OSSW to act as an OS toggle switch considering this board doesn't use a dip switch. Any feedback would be appreciated.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes Jan 27, 2025
View reviewed changes
fauxpark
fauxpark requested changes Jan 28, 2025
View reviewed changes
@adophoxia @waffle87 @fauxpark
Apply suggestions from code review
fa05ca0 
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark requested changes Jan 28, 2025
View reviewed changes
@adophoxia adophoxia requested a review from waffle87 January 28, 2025 02:37
@iamdanielv
Copy link
Contributor

There seems to be something wrong with the LED settings / config on the red version.

I just flashed the code and I can get layers, capslock etc all working fine, but there is no LED backlight.

I tried the BL_TOGG, BL_STEP, LM_BRIU, LM_BRID and nothing happens.

I re-flashed the firmware from the Keychron Launcher page and I get the LEDs back, so there seems to be something wrong with this version.

I built with:

 qmk compile -j 0 -kb keychron/c3_pro/ansi/red/ -km default

@iamdanielv
Copy link
Contributor

Figured it out,

in config.h, should be:
/* LED Matrix Driver Configuration */
#define SNLED27351_I2C_ADDRESS_1 SNLED27351_I2C_ADDRESS_GND

instead of:
/* LED Matrix Driver Configuration */
#define SNLED27351_I2C_ADDRESS_1 SNLED27351_I2C_ADDRESS_VDDIO

iamdanielv
iamdanielv suggested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@iamdanielv iamdanielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SNLED27351_I2C_ADDRESS_1 should be SNLED27351_I2C_ADDRESS_GND

This is tested and works properly on my red keyboard, the old value would not turn on the LEDs.

Cycled through the LED modes and everything seems to be working properly

@adophoxia @iamdanielv
Update keyboards/keychron/c3_pro/ansi/red/config.h
f305c93 
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
drashna
drashna requested changes Jan 29, 2025
View reviewed changes
iamdanielv
iamdanielv approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@iamdanielv iamdanielv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@waffle87 waffle87 merged commit fa98117 into qmk:master Jan 29, 2025
3 checks passed
alk-alyss added a commit to alk-alyss/qmk_firmware that referenced this pull request Jan 30, 2025
@alk-alyss
Merge branch 'master' of https://github.com/qmk/qmk_firmware
07d8f40 
* 'master' of https://github.com/qmk/qmk_firmware: (221 commits)
  Add Keychron C3 Pro (Red & RGB) (qmk#24874)
  [OS Detection] Improve MacOS detection (qmk#24708)
  Bump vite from 5.2.14 to 5.4.12 in /builddefs/docsgen (qmk#24852)
  Reject keyboard.json next to info.json (qmk#24882)
  Add keyboard clap_studio/flame60 (qmk#24870)
  [Keyboard] Add Support E8ghtyNeo (qmk#24859)
  [License Violation] add pressplayid (qmk#24869)
  Fix missing wait.h include in Dip Switch Map (qmk#24863)
  Add Model-B keyboard (qmk#24681)
  Updated Licence Violations for Chosfox L75 (qmk#24833)
  License violations updates. (qmk#24831)
  Add Lily (qmk#24813)
  `kikoslab/kl90`: fix keymap (qmk#24826)
  [Keyboard] Add ic45v2 (qmk#24818)
  Allow running Docker container on MacOS (without in-container USB support) (qmk#24412)
  `salane/ncr80alpsskfl`: add additional layouts (qmk#24809)
  Bump nanoid from 3.3.7 to 3.3.8 in /builddefs/docsgen (qmk#24713)
  Fix a build warning and tidy up a keymap (qmk#24805)
  [Bug] Fix Underglow keycode processing (qmk#24798)
  [Docs] Fix wording in Mod Tap documentation (qmk#24796)
  ...
This was referenced Jan 31, 2025
Closed
Merged
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @Rumadon
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
cd5542f 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia adophoxia mentioned this pull request Feb 1, 2025
Merged
4 tasks
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
7c41a8e 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia adophoxia mentioned this pull request Feb 4, 2025
Merged
14 tasks
thomasc791 pushed a commit to thomasc791/qmk_firmware that referenced this pull request Feb 4, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @thomasc791
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
fd72f30 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
tangyboi3 pushed a commit to tangyboi3/qmk_firmware that referenced this pull request Feb 8, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @tangyboi3
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
6cab963 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
artlugovoy pushed a commit to artlugovoy/qmk_firmware that referenced this pull request Feb 16, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @artlugovoy
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
295572d 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@zvecr zvecr mentioned this pull request Feb 17, 2025
Closed
14 tasks
le4ker pushed a commit to le4ker/lily58-firmware that referenced this pull request Feb 18, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @le4ker
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
fa4da2a 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
haxwagon pushed a commit to haxwagon/qmk_firmware that referenced this pull request Feb 19, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @haxwagon
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
3efd3f3 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
slotThe pushed a commit to slotThe/qmk_firmware that referenced this pull request Feb 24, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @slotThe
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
cedf49d 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
apollovy pushed a commit to apollovy/qmk_firmware that referenced this pull request Feb 24, 2025
@adophoxia @waffle87
@fauxpark @iamdanielv @drashna @apollovy
Add Keychron C3 Pro (Red & RGB) (qmk#24874)
e457bb0 
* Add Keychron C3 Pro variants

* Update to upstream standards

* Apply suggestions from code review

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>

* Reformatted `keyboard.json` for `red`/`rgb` and `c3_pro.c`

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

* Update keyboards/keychron/c3_pro/ansi/red/config.h

Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>

* Add C Pro V2 variants

* remove boards by accident

---------

Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark requested changes

@iamdanielv iamdanielv iamdanielv approved these changes

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adophoxia @iamdanielv @drashna @fauxpark @waffle87