Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate send_string implementations. #24817

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Jan 15, 2025

Description

Consolidates handling of send_string et.al. such that the embedded commands using SS_QMK_PREFIX are consistently handled.

Tested on an AVR board, with string resident in RAM and PROGMEM. Tested with VIA and its use of dynamic_keymap.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team January 15, 2025 22:40
@github-actions github-actions bot added the core label Jan 15, 2025
@tzarc
Copy link
Member Author

tzarc commented Jan 16, 2025

Hmm, not bad, saves 322 bytes for a VIA-enabled build:

% QMK_USERSPACE=$(realpath ..) ./util/size_regression.sh -s 0.27.0 -d HEAD kprepublic/bm16s:tzarc
Size:    26786, delta:   -322 -- d4ec060c39 Consolidate send_string implementations.
Size:    27108, delta:     +0 -- 7b83bb9d26 Allow running Docker container on MacOS (without in-container USB support) (#24412)
Size:    27108, delta:     +0 -- 7f1c236c75 Bugfix and update for AT32F415 (#24807)

@drashna drashna requested a review from a team January 16, 2025 04:02
@zvecr
Copy link
Member

zvecr commented Jan 19, 2025

Would we not need to force SEND_STRING_ENABLE = yes when DYNAMIC_KEYMAP_ENABLE is enabled?

@tzarc
Copy link
Member Author

tzarc commented Jan 19, 2025

Would we not need to force SEND_STRING_ENABLE = yes when DYNAMIC_KEYMAP_ENABLE is enabled?

Was unaware it could be turned on or off, tbh. Have added a make rule to do exactly as you've suggested.

@tzarc tzarc merged commit a6a0dc8 into qmk:develop Jan 20, 2025
4 checks passed
@tzarc tzarc deleted the send_string-consolidation branch January 20, 2025 21:24
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants