Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OS Detection] Improve MacOS detection #24708

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[OS Detection] Improve MacOS detection #24708

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9261f6f
[OS Detection] Improve MacOS detection
drashna Dec 11, 2024
de87483
Add more data and tests
drashna Dec 12, 2024
68f8914
Appease the lint gods
drashna Dec 12, 2024
d81ef55
Add additional tests
drashna Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Appease the lint gods
  • Loading branch information
@drashna
drashna committed Dec 12, 2024
commit 68f89142f6dec3993be6782e025daebbf36a5ef8
2 changes: 1 addition & 1 deletion quantum/os_detection/tests/os_detection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ TEST_F(OsDetectionTest, TestChibiosMacos2) {
}

TEST_F(OsDetectionTest, TestChibiosMacos3) {
EXPECT_EQ(check_sequence({ 0x2, 0x42, 0x2, 0x1C, 0x2, 0x1A, 0xFF, 0x2, 0x42, 0x2, 0x1C, 0x2, 0x1A, 0xFF}), OS_MACOS);
EXPECT_EQ(check_sequence({0x2, 0x42, 0x2, 0x1C, 0x2, 0x1A, 0xFF, 0x2, 0x42, 0x2, 0x1C, 0x2, 0x1A, 0xFF}), OS_MACOS);
os_detection_task();
assert_not_reported();
}
Expand Down
Loading