Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid loading keymap rules.mk twice #24665

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Avoid loading keymap rules.mk twice #24665

merged 1 commit into from
Dec 1, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 1, 2024 •
edited
Loading

Description

When both a keymap.c and keymap.json exist, a rules.mk is loaded multiple times.

Adding a SRC += x.c to a keymap level in this scenario, results in the compilation unit being appended twice, producing "multiple definition of" link issues.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Dec 1, 2024
@github-actions github-actions bot added the core label Dec 1, 2024
@tzarc tzarc merged commit 5eb53be into master Dec 1, 2024
3 checks passed
@tzarc tzarc deleted the zvecr-patch-1 branch December 1, 2024 19:24
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@zvecr @smallketchup82
Avoid loading keymap rules.mk twice (qmk#24665)
5f78122
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@zvecr @ilham-agustiawan
Avoid loading keymap rules.mk twice (qmk#24665)
9f75435
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@zvecr @DmNosachev
Avoid loading keymap rules.mk twice (qmk#24665)
cf62a77
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@zvecr @waffle87
Avoid loading keymap rules.mk twice (qmk#24665)
ceb1c5d
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@zvecr @SyrupSplashin
Avoid loading keymap rules.mk twice (qmk#24665)
39c27c4
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@zvecr @LeonMusCoden
Avoid loading keymap rules.mk twice (qmk#24665)
a58b6a9
ichichou pushed a commit to ichichou/qmk_firmware that referenced this pull request Jan 8, 2025
@zvecr @ichichou
Avoid loading keymap rules.mk twice (qmk#24665)
4ee99d4
MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025
@zvecr @MichaelScofield45
Avoid loading keymap rules.mk twice (qmk#24665)
8a83cfe
pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025
@zvecr @pashashocky
Avoid loading keymap rules.mk twice (qmk#24665)
d545495
Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025
@zvecr @Rumadon
Avoid loading keymap rules.mk twice (qmk#24665)
c6e4cf5
MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025
@zvecr
Avoid loading keymap rules.mk twice (qmk#24665)
eecbbc0
alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025
@zvecr @alinelena
Avoid loading keymap rules.mk twice (qmk#24665)
a3bf620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc