Added support for EnvKB 60F V2 #24642
Open
+181
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed a small oversight in keymap.c
waffle87
reviewed
Nov 26, 2024
Co-authored-by: jack <jack@pngu.org>
zvecr
requested changes
Nov 26, 2024
| KC_TAB, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_LBRC, KC_RBRC, KC_BSLS, | ||
| KC_CAPS, KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_QUOT, KC_NUHS, KC_ENT, | ||
| KC_LSFT, KC_NUBS, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RSFT, | ||
| KC_LCTL, KC_LWIN, KC_LALT, KC_SPC, KC_SPC, KC_SPC, KC_RALT, KC_RWIN, _______, KC_RCTL |
There was a problem hiding this comment.
- Keycode in layout: Press the key mapped to
QK_BOOT. In the pre-supplied keymaps it is on the second layer, replacing the Tab key.
KC_TRANS on a base layer seems like an unusual choice given it doesnt align with the readme comment and the v1 has a 2nd layer?
Co-authored-by: Joel Challis <git@zvecr.com>
Magkoooh
approved these changes
Nov 27, 2024
|
Thank you for your contribution! |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated boards into folders mirroring board revisions, added support for V2 of the board.
Description
Moved V1 and V2 into their own folders, added V2 keymap.c, keyboard.json and a readme.me in each folder.
Compiled and tested the generated UF2 files on both versions of my keyboards to ensure they work as intended.
Types of Changes
Issues Fixed or Closed by This PR
Checklist