Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ambergon/multipleglove #24526

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add ambergon/multipleglove #24526

wants to merge 10 commits into from
+128 −0

Conversation

ambergon
Copy link

add keyboards/ambergon/multipleglove

Description

add my new keyboard map

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

[add]
de574d6 
add keyboards/ambergon/multipleglove
ambergon added 4 commits October 26, 2024 01:19
[fix]
1000715 
DELETE PRODUCT in config.h
RENAME ./keymap/via/via.json -> ./keyboard.json
[fix]
53b7c9f 
keyboard.json -> delete
info.json -> keyboard.json
[fix]
5b76c88 
keymap.c func encoder_map
[fix]
16884b2 
keymap level enable -> ENCODER_MAP_ENABLE 	= yes
zvecr
zvecr requested changes Oct 25, 2024
View reviewed changes
keyboards/ambergon/multipleglove/config.h Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/rules.mk Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/readme.md Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/readme.md Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/ambergon/multipleglove/keyboard.json Outdated Show resolved Hide resolved
@zvecr zvecr changed the title [add] Add ambergon/multipleglove Oct 25, 2024
ambergon and others added 2 commits November 14, 2024 23:24
[fix]
f604342 
DELETE ./config.h
DELETE ./rules.mk
FIX    ./readme.md
FIX    ./keymaps/default/rules.mk
    remove ENCODER ENABLE
FIX    ./keyboard.json
    add encoder true
    add layer 16
FIX    ./keymaps/default/keymap.c

thank @zvecr!
@ambergon
Merge branch 'qmk:master' into master
9232f82
@ambergon ambergon requested a review from zvecr November 15, 2024 04:42
@zvecr
Copy link
Member

zvecr commented Nov 15, 2024

Theres not much point requesting review, when you still have outstanding requested changes.

@ambergon
Copy link
Author

First, let me apologize for not understanding the “Commit suggestion and Add suggestion to batch” feature of github, and thus not being able to incorporate it properly.

ambergon and others added 2 commits November 15, 2024 15:36
@ambergon @zvecr
Update keyboards/ambergon/multipleglove/keyboard.json
7bc3877 
Co-authored-by: Joel Challis <git@zvecr.com>
[fix]
2334341 
readme hakugin lab -> shirogane lab
keyboard.json delete resolution
@ambergon
Copy link
Author

I understand the role of the “Files change tab”.
Sorry for being rude.

@ambergon
Copy link
Author

The matrix_scan_user function, which you recommended to turn off,
I would like to keep it because it is the core function of the keyboard.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 31, 2024
@ambergon @drashna
Update keyboards/ambergon/multipleglove/keymaps/default/keymap.c
eff22b5 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 4, 2025
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambergon @zvecr @drashna