Fix rendering of `keymap_config.no_gui` within `led_update_kb` #24473

zvecr · 2024-10-11T19:47:50Z

Description

Using host led callbacks to render will not correctly catch the cases where keymap_config.no_gui is mutated.

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

…4473)

* Fix `thumbsup:default` keymap (#24459) * Fix Caps Lock indication on Valhalla v2 (#23012) * Fix Caps Lock indication * User LED state function override added Co-authored-by: Drashna Jaelre <drashna@live.com> * Change backlight enabled check and remove backlight headers Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: Drashna Jaelre <drashna@live.com> * add ergodox Community Layout for LAYOUT_ergodox keyboards (#22963) initial commit * Fix indicator code for NK classics (#24462) Fix indicator code Co-authored-by: yiancar <yiancar@gmail.com> * Fixup Lily58 keymap comment (#24466) * Expand count checks in keymap introspection (#24464) * Add check Tap Dance count check to keymap introspection * Add checks for combos and key overrides to introspection * [Keyboard] Add Piantor UV 44 (#24247) Co-authored-by: Ryan <fauxpark@gmail.com> * Add Ploopyco functions for host state control (#23953) * Add Scotto37 handwired keyboard (#23938) Co-authored-by: Joel Challis <git@zvecr.com> * fix hotdox76v2 oled font to more closely mirror utf8 (#23807) * `mykeyclub/jris65/hotswap`: fix keymap (#24472) * Fix duplication of core `GU_TOGG` keycode (#24474) * Fix rendering of `keymap_config.no_gui` within `led_update_kb` (#24473) * Rename RGB and HSV structs (#24471) * Update combo user function variable (#24467) * Add svlinky converter (#24449) * zsa/moonlander: Fix execution of user callback (#24475) * Separate RGBLight/RGB Matrix keycode handling (#23679) * Separate RGBLight/RGB Matrix keycode handling * Remove `_DISABLE_KEYCODES` handling * Update RGB Matrix keycode docs * Update underglow keycodes for previously migrated boards * Update keycodes for boards with custom handling * Fix typos * Fix bad merge * [Core] quantum: util: add bit and bitmask helpers (#24229) quantum: util: add bit and bitmask helpers These helpers are handy and can prevent off-by-one errors when working with registers and general low level bit manipulation tasks. The macros themself are inspired by the bits.h macros from the linux kernel source code. Signed-off-by: Stefan Kerkmann <karlk90@pm.me> Co-authored-by: Pascal Getreuer <50221757+getreuer@users.noreply.github.com> * Rename RGB/HSV structs: keyboard-level code (#24476) * keebio/nyquist: Remove invalid I2C config (#24479) * xiudi/xd002: Remove broken oversized `multilayer_rgb` keymap (#24480) * horrortroll/nyx/rev1: Fix compilation of custom RGB effect (#24481) * Digitizer: fix units tag in report descriptor (#24482) * [Keyboard] Add JK60 RGB (#24485) * add vector macropad (#24487) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <jack@pngu.org> Co-authored-by: Ryan <fauxpark@gmail.com> * [Core] `usb_device_state`: consolidate usb state handling across implementations (#24258) * usb_device_state: add idle_rate, led and protocol Previously all usb drivers and platform implementations (expect for our oddball atsam) tracked the same two global variables: - keyboard_protocol: to indicate if we are in report or boot protocol - keyboard_idle: for the idle_rate of the keyboard endpoint And a local variable that was exposed trough some indirection: - keyboard_led_state: for the currently set indicator leds (caps lock etc.) These have all been moved into the usb_device_state struct wich is accessible by getters and setters. This reduces code duplication and centralizes the state management across platforms and drivers. Signed-off-by: Stefan Kerkmann <karlk90@pm.me> * usb_device_state: reset protocol on reset The usb hid specification section 7.2.6 states: When initialized, all devices default to report protocol. However the host should not make any assumptions about the device’s state and should set the desired protocol whenever initializing a device. Thus on reset we should always do exactly that. Signed-off-by: Stefan Kerkmann <karlk90@pm.me> * keyboards: fix oversize warnings Signed-off-by: Stefan Kerkmann <karlk90@pm.me> --------- Signed-off-by: Stefan Kerkmann <karlk90@pm.me> * Correct layouts/default/readme.md (#23805) Update readme.md remove orphan layout * [Bug] Fix compiliation issues with OS Detection (#24502) * Rename saevus to concreteflowers (#24249) * Fix 6x13 default keymap (#24509) Update keymap.c * Add Iris LM series of keyboards (#24510) * RGBLight: Improve RGB Test animation (#24477) * [Keyboard] Add xdboards/recon keyboard (#24135) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add SIRIND Tomak79H (#24505) * Add Tomak79H Add Tomak79H * Update Update * Update keyboards/era/sirind/tomak79h/tomak79h.c Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: Drashna Jaelre <drashna@live.com> * Add Vanguard65 Keyboard (#24497) * Initial commit * update * added two options for the slider * comments * added rounding for the lower end of the LED values * moved folder, cleaned up code * fixed layout def * fioxed default layout * Update keyboards/keebfront/vanguard65/config.h Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/readme.md Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/rules.mk Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: jack <0x6a73@protonmail.com> * updated default keymap to have encoder map functionality * Update keyboards/keebfront/vanguard65/rules.mk Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/config.h Co-authored-by: jack <0x6a73@protonmail.com> * Update keyboards/keebfront/vanguard65/config.h Co-authored-by: jack <0x6a73@protonmail.com> * add encoder_update_kb * Update keyboards/keebfront/vanguard65/vanguard65.c Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/keebfront/vanguard65/vanguard65.c Co-authored-by: Drashna Jaelre <drashna@live.com> * new qmk * misc fixes * Test * Removed extraneous parts of hte rules.mk * Remove extra layers in the keymap * Revert "Remove extra layers in the keymap" This reverts commit c82ee931acef589c8ef260e26a3de7ecd88acb53. * removed excess layers * update for latest QMK led definition * update * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Delete vanguard65.c * run qmk format_json * Update keyboards/keebfront/vanguard65/rules.mk Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/keebfront/vanguard65/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Update keyboards/keebfront/vanguard65/keymaps/default/keymap.c Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Confirm all keymaps compile * update for latest QMK best definitions * Apply suggestions from code review Co-authored-by: jack <jack@pngu.org> * Added minimum slider functionality. * update readme * Apply suggestions from code review Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/keebfront/vanguard65/keyboard.json Co-authored-by: jack <jack@pngu.org> --------- Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: jack <jack@pngu.org> Co-authored-by: Joel Challis <git@zvecr.com> * Add timer_save and _restore functions. (#23887) Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Nick Brassel <nick@tzarc.org> * Move pointing device driver code (#24445) Co-authored-by: Drashna Jaelre <drashna@live.com> * Add madjax_macropad keyboard (#24524) Co-authored-by: Ryan <fauxpark@gmail.com> * Refactor Riverflow matrix effect with runner (#24520) Co-authored-by: Ryan <fauxpark@gmail.com> * Update Pixel Rain to respect LED range limits (#24532) * Update Jellybean Raindrops to respect LED range limits (#24534) * Refactor Breathing effect with runner (#24535) * Improve consistency of syntax within `data/constants/keycodes` (#24528) * Change default ARM hardware PWM WS2812 tick frequency to 800kHz (#24508) * [Keyboard] Add S6xty PCB (#24465) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Trần Thanh Sơn <son.tt1@teko.vn> * Refactor LED Breathing effect with runner (#24540) * Cipulot Updates (#24539) * [Keyboard] Add Singa Kohaku (#24309) Co-authored-by: jack <jack@pngu.org> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Handle `cli._subcommand.__name__` deprecation warning (#24533) * Remove `appdirs` from `requirements.txt` (#24550) * Handle 'MILCInterface' object has no attribute 'log_level' error (#24549) * Bump minimum required Python version (#24554) * [Keyboard] Add KLEC-01 (#24543) * Add new keyboard "KLEC-02" (#24559) Co-authored-by: jack <0x6a73@protonmail.com> * Add keyboards/converter/thinkpad_t6x/rpi_pico (#23696) * Adding SdraKb00 keyboard (#24552) Co-authored-by: jack <jack@pngu.org> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add Teton78 (#24562) * Added Teton_78 qmk keyboard files * Fixed a syntax issue * Waffles suggested changes * Read me updated Used the Alpine65 reame to model off. * Update keyboards/mountainmechdesigns/teton_78/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> * Accidental File * Updated readme with missing info * Update readme.md * Update keyboards/mountainmechdesigns/teton_78/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mountainmechdesigns/teton_78/readme.md Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mountainmechdesigns/teton_78/readme.md Co-authored-by: Joel Challis <git@zvecr.com> --------- Co-authored-by: jack <jack@pngu.org> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> * Adding support for Windstudio's Wind X R1 keyboard (#24564) * Added a default firmware and layout for the WindStudio Wind X R1 keyboard. * Wind X R1: cleaned-up the folders to make clear that this firmware is for the release 1 of this keyboard. * Added rules.mk to the default layout * Renamed the folder R1 into r1. * Added readme.md files for the keyboard and default layout. * Added a license header to keymap.c * Update keyboards/windstudio/wind_x/r1/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/windstudio/wind_x/r1/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/windstudio/wind_x/r1/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> * Update keyboards/windstudio/wind_x/r1/readme.md Co-authored-by: jack <jack@pngu.org> * Added a proper link to the image (logo of windstudio) * Wind X R1 - Corrected the default keymap with the QK_GESC key instead of the KC_ESC. - Removed the unnecessary rules.mk in the default layout * Wind X R1: applied `qmk format-json -i` on keyboard.json to conform with the project formatt standards. * Added a picture of the keyboard. * Added a caption to the image. --------- Co-authored-by: jack <jack@pngu.org> * Add keyboard buff75 (#24297) * Create herevoland * Delete keyboards/herevoland * Add files via upload * Delete keyboards/herevoland/buff75 directory * Add files via upload * Delete keyboards/herevoland/buff75/buff75.h * Delete keyboards/herevoland/buff75/rules.mk * Delete keyboards/herevoland/buff75/halconf.h * Update and rename info.json to keyboard.json * Delete keyboards/herevoland/buff75/matrix_diagram.md * Update readme.md * Update readme.md * Add files via upload * Delete keyboards/herevoland/buff75/keymaps/via directory * Update readme.md * Update keymap.c * Update matrix_diagram.md * Update readme.md * Update keyboard.json * Update readme.md * Update matrix_diagram.md * Update keyboard.json * Update keymap.c * Update keymap.c * Update keyboard.json * Update mcuconf.h * Delete keyboards/herevoland/buff75/mcuconf.h * Speed improvements to `qmk find`. (#24385) * Expose rgb_matrix_update_pwm_buffers to be available in keymaps (#24573) * Expose rgb_matrix_update_pwm_buffers to be available in keymaps Exposing this API enables the examples in the keyboard shutdown/reboot documentation to compile instead of calling `rgb_matrix_driver.flush` directly. * Remove extraneous rgb_matrix_update_pwm_buffers prototype declarations Now that `rgb_matrix_update_pwm_buffers` is public, there isn't the need for local prototype declarations. * added support for shorty KB (#24518) * added support for shorty KB Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Add Idyllic Pizza Pad (#24566) * Initial PizzaPad firmware * Updated files to conform to PR checklist * Fix default keymap location * Update keyboard.json * Apply suggestions from code review Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/idyllic/pizzapad/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> --------- Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <jack@pngu.org> * Add Fuyu HS (#24567) * Add Fuyu HS * Fix keyboard.json linting * Fix rgbmatrix configuration * Apply suggestions from code review Co-authored-by: Joel Challis <git@zvecr.com> --------- Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add tenstad (#24571) * [Keyboard] Add tenstad * fix: remove settings disabled by default Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * fix: add serial and transport to json Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * fix: format json * docs: update img url * fix: delete now-redundant rules.mk * fix: format keymap.json (keeping 'layout' at the top) --------- Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * [docs] Fix dead link to keyboard list in newbs.md (#24579) * [docs] Turn on icons for external links (#24580) * Joystick: add support for 8-way hat switch (#24515) * remove "w": 1 from /keyboards/ (#24587) * Bump JamesIves/github-pages-deploy-action from 4.6.8 to 4.6.9 (#24592) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.8 to 4.6.9. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](https://github.com/jamesives/github-pages-deploy-action/compare/v4.6.8...v4.6.9) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [docs] Add "edit this page" link at the bottom (#24585) * [Keyboard] Add Majestouch Redux (#24586) * [Keyboard] Add Majestouch Redux * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> --------- Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Perform test compiles during `qmk doctor`. (#24282) Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * Revert removal of `QK_OUTPUT_AUTO`, fixup docs to reflect. (#24593) * [docs] Improve halconf/mcuconf code examples (#24597) * docs: move description of host_language from Macros to Language-specific Keycodes (#24584) Co-authored-by: フィルターペーパー <76888457+filterpaper@users.noreply.github.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard]Add Lily58 Lite Rev3(lily58/lite_rev3) (#24255) * add Lily58 Lite Rev3 Firmware * fix README * Update README * delete lite_rev3.h * Update keyboards/lily58/lite_rev3/halconf.h Co-authored-by: jack <jack@pngu.org> * Update keyboards/lily58/lite_rev3/config.h Co-authored-by: jack <jack@pngu.org> * Update keyboards/lily58/lite_rev3/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/lily58/lite_rev3/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/lily58/lite_rev3/mcuconf.h Co-authored-by: jack <jack@pngu.org> * fix image url * fix SERIAL_DRIVER definition * fix VIA_ENABLE definition disable * fix cols pin * Update keyboards/lily58/lite_rev3/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/lily58/lite_rev3/keyboard.json Co-authored-by: jack <jack@pngu.org> * delete rules.mk * Update README * Update keyboards/lily58/lite_rev3/readme.md --------- Co-authored-by: jack <jack@pngu.org> Co-authored-by: Drashna Jaelre <drashna@live.com> * docs: fix RWIN alias (#24610) * Fix typo in docs/api_development_overview.md (#24620) * Add Sagittarius encoder support. (#24617) * Backward compatibility for new RGB keycode handling (#24490) Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> * [CLI] Refactor painter arguments to table instead of commandline (#24456) Co-authored-by: Nick Brassel <nick@tzarc.org> * `qmk new-keymap`: validate keymap name (#23420) * `qmk via2json`: Improve macro parsing (#24345) * `qmk new-keyboard`: separate dev board and MCU selection (#24548) * Added MCU support for ArteryTek AT32F415 (#23445) * [Core] Add Layer Lock feature (#23430) Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com> Co-authored-by: Pascal Getreuer <getreuer@google.com> Co-authored-by: Pascal Getreuer <50221757+getreuer@users.noreply.github.com> * Bring supported STM32F4 configs in line with F4x1 (#24413) Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * `qmk find`: expand operator support (#24468) * Review fixes for layer lock feature (#24627) * Fix rendering of `reference_configurator_support.md` (#24629) * [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (#24630) * [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (#21881) * Apply suggestions from code review Co-authored-by: Nick Brassel <nick@tzarc.org> --------- Co-authored-by: Nebuleon <2391500+Nebuleon@users.noreply.github.com> Co-authored-by: Nick Brassel <nick@tzarc.org> * Update keymaps to use PDF keycode (#24633) * Simple Python script to show polling rate (#24622) * Add pointing tests (#24513) * Remove keyboard use of eeconfig_read_default_layer (#24635) * Allow codegen of `keymap.json` => `keymap.c` without requiring layers/layout etc. (#23451) * Update keycodes for keyboards with RGB Matrix (#24484) * Provide method to save a single default layer in the full range of 0-31 (#24639) * `develop` 2024q4 changelog. (#24638) * Merge point for 2024q4 breaking change. * Bump JamesIves/github-pages-deploy-action from 4.6.9 to 4.7.1 (#24654) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.9 to 4.7.1. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](https://github.com/jamesives/github-pages-deploy-action/compare/v4.6.9...v4.7.1) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update leftover RGB keycodes (#24653) * Improve "feature/encoder config both specified" warnings (#24641) * Avoid loading keymap rules.mk twice (#24665) * [Keyboard] Add fistbnmp (#24595) * Add Xlant XL keyboard (#24608) Co-authored-by: jack <jack@pngu.org> * Addition of Hotdog Pad (#24650) * Add Hotdog Pad * remove encoder_map feature * Add rules.mk * move rules.mk into keymap * Update keyboards/onnenon/hotdog_pad/keyboard.json Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/onnenon/hotdog_pad/keyboard.json Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/onnenon/hotdog_pad/keymaps/default/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * Update keyboards/onnenon/hotdog_pad/keymaps/default/keymap.c Co-authored-by: Joel Challis <git@zvecr.com> * add hotdog_pad.c * fix reversed encoder pins * Update keyboards/onnenon/hotdog_pad/hotdog_pad.c Co-authored-by: Joel Challis <git@zvecr.com> --------- Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Added nibell micropad4x4 (#24662) * feat: added nibell micropad4x4 * chore: updated readme * chore: updated keymap * feat: added layers * chore: added bootloader doc * Added layers * changed RSHIFT and RCTRL * Update keyboards/nibell/micropad4x4/keyboard.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/nibell/micropad4x4/readme.md --------- Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <jack@pngu.org> * sawnsprojects/bunnygirl65: Fix typo in name (#24668) * [Keyboard] Add support E8ghty (#24632) * Update support S6xty5 * Delete chconf.h * Update manufacturer, community layout for hhkb * Update layout * fix row index * Update tyson60s * Update community layout and layout name * Update remove rgb test mode * Update capslock led * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Remove deprecated s6xty5 * Update support for E8ghty * remove rgb test mode * Update community layout * Update fix pipeline build ci * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> --------- Co-authored-by: Trần Thanh Sơn <son.tt1@teko.vn> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add suika27melo (#24616) * add keyboard suika27melo * Update keyboards/suikagiken/suika27melo/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/suikagiken/suika27melo/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/suikagiken/suika27melo/readme.md Co-authored-by: jack <jack@pngu.org> * Update keyboards/suikagiken/suika27melo/readme.md Co-authored-by: jack <jack@pngu.org> * change to imgur link --------- Co-authored-by: jack <jack@pngu.org> * [Keyboard] Add support S6xty5Neo Rev.2 (#24631) * Update support S6xty5 * Delete chconf.h * Update manufacturer, community layout for hhkb * Update layout * fix row index * Update tyson60s * Update community layout and layout name * Update remove rgb test mode * Update capslock led * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add support for S6xty5Neo Rev.2 * Remove deprecated s6xty5 * Update layout * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Move mcuconf and config to outer folder --------- Co-authored-by: Trần Thanh Sơn <son.tt1@teko.vn> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [murcielago] Enable split watchdog (#24463) * [Keyboard] Add h88 gen2 (#24454) * initial commit * small updates * matrix fix * fix rgb lighting * updates * fix rgb pin * pin fixes * readme update * json formatting * Update keyboards/hineybush/h88_g2/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Add new keyboard "Jourkey" (#24409) * jourkey * rotary encoder * fix keymap * jourkey * format json * Update keyboards/takashicompany/jourkey/readme.md Co-authored-by: Joel Challis <git@zvecr.com> * fix layout * Update readme.md --------- Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add splitkb.com's Halcyon Kyria rev4 (#24512) * Add Halcyon Kyria Rev4 * Remove bootmagic and unused features * Fix encoderindex * Update readme.md * Remove rgblight * Implement requested changes * Add encoder update user * Remove rules.mk and add VIK configuration * Move options to config.h * Update RGB keycodes (qmk#24484) * implement changes --------- Co-authored-by: harvey-splitkb <126267034+harvey-splitkb@users.noreply.github.com> * [Keyboard] Add NCR80 ALPS SKFL/FR (#24625) * ADD NCR80 ALPS SKFL/FR * fix * Update config.h * Update config.h * Update keyboards/salane/ncr80alpsskfl/keyboard.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/salane/ncr80alpsskfl/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/salane/ncr80alpsskfl/readme.md Co-authored-by: jack <jack@pngu.org> --------- Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <jack@pngu.org> * [Keyboard] Add keyboard reviung46 (#24245) * add keyboard reviung46 * modified keyboards/reviung/reviung46/readme.md * modified keyboards/reviung/reviung46/keyboard.json * modified keyboards/reviung/reviung46/readme.md * fix keyboards/reviung/reviung46/keyboard.json * fix keyboards/reviung/reviung46/keymaps/default/keymap.c fix keyboards/reviung/reviung46/keymaps/via/keymap.c * fix keyboards/reviung/reviung46/keymaps/via/keymap.c * fix keyboards/reviung/reviung46/keyboard.json * fix keyboards/reviung/reviung46/keyboard.json * modified reviung/reviung46/readme.md * fixed keyboards/reviung/reviung46/keyboard.json * fixed keyboards/reviung/reviung46/keymaps/default/keymap.c deleted keyboards/reviung/reviung46/keymaps/via/keymap.c deleted keyboards/reviung/reviung46/keymaps/via/rules.mk * fix keyboards/reviung/reviung46/keyboard.json and keyboards/reviung/reviung46/keymaps/default/keymap.c * Update keyboards/reviung/reviung46/readme.md --------- Co-authored-by: jack <jack@pngu.org> * Update hardware_keyboard_guidelines.md to Fix Typos (#24671) Corrected a typo in the phrase "iOS device need lessthan 100" to "iOS devices need less than 100." This was to improve clarity and professionalism of the doc. * Bump JamesIves/github-pages-deploy-action from 4.7.1 to 4.7.2 (#24672) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.7.1 to 4.7.2. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](https://github.com/jamesives/github-pages-deploy-action/compare/v4.7.1...v4.7.2) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add cornia keyboard (#24442) * Add cornia keyboard * Update Fire keymap * [Cornia/Doc] Host image on imgur * [Cornia/config] Remove unnecessary defines * [Cornia] Move I2C stuff to keyboard level * [Cornia/config] Remove unnecessary defines & move all callbacks to keymap.c * [Cornia] Use tri-layer in default keymap * [Cornia/makefiles] remove license headers & root makefile * [Cornia] Put common configuration to top keyboard level * [Cornia] Remove unecessary custom keycodes * [Cornia] Fix readme * [Cornia] Fix RGB keycodes * [Cornia] Fix config files * [Cornia] Fix readme * [Cornia] Fix mcuconf.h license * Add a keyboard entry for yacobo model m replacement control boards (#23827) * add the keyboard * Update keyboards/ibm/model_m/yacobo/keyboard.json Co-authored-by: jack <0x6a73@protonmail.com> * remove dead file * PR Comments * standardize comments * PR Comments --------- Co-authored-by: Stephen Edwards <stephenedwardsemail@gmail.com> Co-authored-by: jack <jack@pngu.org> * [Keyboard] Add dactyl_manuform_pi_pico (#23891) Adds new keyboard under handwired/dactyl_manuform_pi_pico It is a dactyl_manuform(5x6) running on Pi Pico micro controller * [Keyboard] Add cans12erv2 (#24628) Co-authored-by: jack <jack@pngu.org> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Can Baytok <baytok@dydocon.com> * [Keyboard] Add Marcopad (#24636) * Marcopad debut * Applying core review suggestions * Optional layout with backlit * Line feeds and replacing dev board configs * Function to toggle backlight * Move to RGB Matrix * Fixing capitalization * Review comments --------- Co-authored-by: Marco Pelegrini <mpelegrini@microsoft.com> * Addition of EC Constellation (#24644) * Addition of EC Constellation * Fix layout macro name * Addition of EC1-AT (#24645) * [Keyboard] add kbd0 Curve0 60 ANSI (#24609) * add kbd0/curve0/60_ansi keyboard * Apply suggestions from code review Co-authored-by: jack <jack@pngu.org> * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> --------- Co-authored-by: unknown <code-monke> Co-authored-by: jack <jack@pngu.org> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add Binepad BNK8 keyboard (#24598) * Add Binepad BNK8 keyboard * Moved keymap.c to keymap.json * Fix product page URL * RGB_ -> RM_ keycodes after this round of breaking changes Co-authored-by: Ryan <fauxpark@gmail.com> --------- Co-authored-by: Ryan <fauxpark@gmail.com> * Add Cerberus to QMK (#24226) * Add Cerberus to QMK * Update readme to add hotswap callouts * Update readme formatting * Use format json to update keyboard.json formatting * Split Cerberus HS and Solderable into separate folders * Update JSON formatting * make solderable keymaps a bit more useful * Backlight fix on solderable * Update keyboards/cannonkeys/cerberus/hotswap/keyboard.json Co-authored-by: jack <jack@pngu.org> * Remove cerberus VIA keymaps * Apply suggestions from code review Change some whitespace Co-authored-by: Drashna Jaelre <drashna@live.com> * Add RGB control keycodes to cerberus keymap * Add backlight controls to default keymap on solderable version * Update keyboards/cannonkeys/cerberus/readme.md --------- Co-authored-by: jack <jack@pngu.org> Co-authored-by: Drashna Jaelre <drashna@live.com> * Fix keymap.json error of keyboard/suikagiken/suika27melo (#24677) * Add Macroflow Original macropad firmware (#24538) * Adding Macroflow Macropad * Macroflow_Macropad * Macroflow_Macropad * Adding My Macropad * Adding Macroflow Macropad * Adding Macroflow Macropad * Adding Macroflow Macropad * Adding Macroflow Macropad * Adding Macroflow Macropad * Added License Headers * Updated code for merge * Added License Header * Added Encoder Map * Updated Files * Fixed Matrix * Update keyboards/macroflow_original/keyboard.json Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/macroflow_original/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/macroflow_original/keymaps/default/keymap.c Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/macroflow_original/keymaps/default/rules.mk Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/macroflow_original/macroflow_original.c Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: Drashna Jaelre <drashna@live.com> * Organise default community layouts summary (#24500) * Organise default community layouts summary * Remove erroneous layout * [Keyboard] Add SIRIND Tomak79S (#24684) * Add Tomak79S Add Tomak79S * Update keyboards/era/sirind/tomak79s/keymaps/default/keymap.c Co-authored-by: jack <0x6a73@protonmail.com> --------- Co-authored-by: jack <jack@pngu.org> * Adding new keyboard Promenade RP24S (#24689) * adding keymaps for krado industries * Modified default keymap.c files to be the same as via. * Changing vendor ID for Krado Industries * Suggested changes made Making changes suggested by zvecr. Removed dynamic_layer indicator, updated copyright year, deleted unused layers in keymaps. Co-authored-by: Joel Challis <git@zvecr.com> * rgbpin for ws2812 changed in info.json * Added encoder mapping rule file for default keymaps; added Fn layer shortcuts to Promenade layouts * Added rules.mk with encoder mapping for encoder boards at keymaps level. * Deleted extra key in LAYOUT * Update keyboards/kradoindustries/kousa/rules.mk Move WS2812 Driver from rules.mk to info.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/kradoindustries/kousa/info.json Move WS2812 Driver from rules.mk to info.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/kradoindustries/kousa/keymaps/default/keymap.c Move WS2812 Driver from rules.mk to info.json Co-authored-by: jack <jack@pngu.org> * Reverting settings.json * Encoder map code change [2]>[NUM_DIRECTIONS] * Adding Promenade RP24S Adding Promenade RP24S keyboard.json, default keymap, and readme * Adding layer access to Promenade RP24S Adding layer access to layers 1 and 2 --------- Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <jack@pngu.org> * fix: KC_MEDIA_PLAY_PAUSE label (#24693) * Adding ctrl-M replacement controller for IBM Model M (#24375) * This is a configuration of QMK intended to be used with the [ctrl-M controller](https://github.com/nuess0r/ctrl-M). * Move USB_MAX_POWER_CONSUMPTION to data driven due to upstream change * Clean up according to PR checklist Check the keymaps/nuess0r how you can make better use of your Model M including Windows, multimedia keys etc. * Move CAPS_HOLD feature from default build to custom keymap * More data driven configuration Move layout definition from ctrl_m.h to info.json Move has_ghost to info.json -> this makes the config.h file obsolete * Implement changes suggested by review * Removing user keymap (nuess0r) to follow current guidelines The nuess0r keymap which is shipped with the ctrl-M controller is kept here: https://github.com/nuess0r/qmk_firmware/tree/nuess0r_keymap * Changed image hosting location to Github requested in review by drashna * Changed image hosting location to imgur * Settings removed from info.json that are disabled by default. * Change URL as suggested by @dunk2k Not pointing to the QMK firmware but to the replacement controller electronics project. * Migrate build target markers to keyboard.json * Adding tindie link and implement review suggestions * Removing via keymap to follow current guidelines Will be moved to the https://github.com/the-via/qmk_userspace_via repo. * Add LAYOUT_all to support ANSI and ISO keyboards with the same firmware Add a LAYOUT_all similar to other keyboards that defines all available keys. Change the default keymap to use the _all layout so both ANSI and ISO Model M variants work out of the box. * Remove unnecessary enum from default keymap Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> --------- Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * [Keyboard] Add Orbweaver (#24692) * Create README.md * Add files via upload * Create keymap.c * Update README.md * Update keyboards/lostdotfish/rp2040_orbweaver/README.md Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/lostdotfish/rp2040_orbweaver/keyboard.json Co-authored-by: Drashna Jaelre <drashna@live.com> * Rename README.md to readme.md * Update readme.md * Update keyboards/lostdotfish/rp2040_orbweaver/keyboard.json Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboards/lostdotfish/rp2040_orbweaver/mcuconf.h Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboard.json * Update keyboards/lostdotfish/rp2040_orbweaver/config.h Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keyboard.json * Update mcuconf.h * Update rp2040_orbweaver.c * Delete keyboards/lostdotfish/rp2040_orbweaver/halconf.h * Update config.h * Update readme.md * Update readme.md * Update readme.md * Update keyboards/lostdotfish/rp2040_orbweaver/keyboard.json --------- Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <jack@pngu.org> * Addition of EC65X (#24648) * Addition of EC TKL X (#24647) * [Keymap] Update rp2040_orbweaver (#24704) * Update keymap.c enhancement - power down indicator LEDs when host sleeps * Update keyboards/lostdotfish/rp2040_orbweaver/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> * Update keyboards/lostdotfish/rp2040_orbweaver/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> --------- Co-authored-by: jack <jack@pngu.org> * Added VT-40 keyboard (#24706) * Added VT-40 keyboard * Remove commented out code. Oops Co-authored-by: jack <jack@pngu.org> * Change name of planck_layers to layers. Co-authored-by: jack <jack@pngu.org> * Update keyboards/vt40/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> * Removed unused features that I stole from the contra config * Removed unused features that I stole from the contra config * fixed lower/raise keys * make adjust layer accessible * Added adjust key for real this time * Update keyboards/vt40/keyboard.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> --------- Co-authored-by: jack <jack@pngu.org> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add licensing violations page. (#24697) * [Keyboard] add swagkeys eave (#24711) * add swagkeys eave * fix up * Update keyboards/swagkeys/eave/keyboard.json Co-authored-by: jack <jack@pngu.org> * Update keyboards/swagkeys/eave/keymaps/default/keymap.c Co-authored-by: jack <jack@pngu.org> --------- Co-authored-by: Xelus22 <> Co-authored-by: jack <jack@pngu.org> * [Keyboard] swagkeys integral (#24712) swagkeys integral Co-authored-by: Xelus22 <> * Resolve `cli.log.warn` warnings (#24551) * [Keyboard] wilba_tech/wt45_h1 (#24717) * Add Reverie to QMK (#24227) * Add Reverie to QMK * Add backlight to reverie * Update reverie readme and copyright notices * Use format json to update keyboard.json formatting * Update to have solderable and hotswap variants split * Update copyright noticeS * JSON formatting updates * inherit config.h * fix broken keymap * Update reverie hs keyboard.json to be accurate * Update keyboards/cannonkeys/reverie/hotswap/keyboard.json Co-authored-by: jack <jack@pngu.org> * Remove VIA keymaps * Update keymap --------- Co-authored-by: jack <jack@pngu.org> * fix: mechwild/bb65 coordinate mix-up (#24738) * [Keyboard] Add keycult 1800 (#24729) Co-authored-by: jack <jack@pngu.org> Co-authored-by: yiancar <yiancar@gmail.com> * Clarify keymap location and format in newbs_building_firmware.md (#24663) * DecenTKL main keyboard (#24702) * DecenTKL numpad (#24696) * [Keyboard] Add SIRIND Brick65S (#24315) Co-authored-by: Joel Challis <git@zvecr.com> * add mellow keyboard (#24319) Co-authored-by: jack <jack@pngu.org> Co-authored-by: Drashna Jaelre <drashna@live.com> * add chlx piche (#24252) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com> * [Keyboard] Add Somei70 (#24444) * Somei70 addition * Changes made, added VIA keymap, cleaned formatting * keymap via * Create rules.mk * Add files via upload * Delete keyboards/somei70/keymaps/via directory * Fixed RGB and matrix * Layout corrections and LED positions * removal of rules.mk * Moved OLED Settings to somei70.c, formatted C removed TABs, removed _LAYERC * Forgot to include license header * Further changes as per suggestions, replaced _user for _kb within somei70.c * Updated keymap 'changes in Nov24' * Requested changes * Set custom effect defines for LED Matrix (#24745) * Add ArteryTek AT32 dfu to udev rules (#24747) * [bug] Djinn theme fix. (#24754) Theme fix. * Skip parsing g_led_config when matrix_size is missing (#24739) * [Keyboard] Ghoul TKL (#24762) Co-authored-by: jack <jack@pngu.org> * Remove invalid "effect_max" animation from keyboards (#24767) * Fix g_led_config parse warning (#24769) * [CI] Regenerate Files (#24770) Regenerate Files * Fix link to TMK magic commands (#24773) * [Keyboard] Add handwired/dactyl_manuform/5x8 (#24726) * add handwired/dactyl_manuform/5x8 config * add keymap scheme * Update keymap.c * Update keyboard.json * Update keyboard.json * fix and compile worked configs * Update readme.md * Update readme.md * Update readme.md * add dynamic macros support * change key sets on first workday/add right2left layer * Update keyboard.json * Update keymap.c * move license header to top keymap.c * Update keyboard.json * I rewrote the layout so that the halves are not stacked. * I rewrote the layout so that the halves are not stacked (keymap.c) * change "serial pin" syntactic change "soft_serial_pin": "D0" to "serial": { "pin": "D0" } * fix KC_BSPC and KC_SPC on right keyboard * Update readme.md * Update keymap.c Co-authored-by: Drashna Jaelre <drashna@live.com> * Update keymap.c Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: skandiPC <slinkinfs@yandex.ru> Co-authored-by: iliorik-ph <140731596+iliorik-ph@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Add shuguet shu89 (#24758) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <jack@pngu.org> * Update some changes for AT32F415 (#24766) * Fixed SPI can't compiled issue * Added solenoid support and use 256KB ldscript for Onekey board * [Keyboard] Add 3W6HS (#22539) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> * Add EE_HANDS for KLEC-02 (#24777) Add #define EE_HANDS * Fix durgod k3x0 docs (#24774) * Remove preprocessor sanity check for STM32L0/L1 now that it relies on types in C. (#24793) * Convert stray legacy warn/info docs panels (#24799) * [Docs] Fix wording in Mod Tap documentation (#24796) * [Bug] Fix Underglow keycode processing (#24798) Co-authored-by: Ryan <fauxpark@gmail.com> * Fix a build warning and tidy up a keymap (#24805) * Bump nanoid from 3.3.7 to 3.3.8 in /builddefs/docsgen (#24713) Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](https://github.com/ai/nanoid/compare/3.3.7...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * `salane/ncr80alpsskfl`: add additional layouts (#24809) * Allow running Docker container on MacOS (without in-container USB support) (#24412) * [Keyboard] Add ic45v2 (#24818) * adding in ic45 handwired * fix wrong title * Apply suggestions from code review Thank you @waffle87 Co-authored-by: jack <jack@pngu.org> * Update keyboards/handwired/ic45_v2/keyboard.json adding whitespace Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: jack <jack@pngu.org> Co-authored-by: Drashna Jaelre <drashna@live.com> * `kikoslab/kl90`: fix keymap (#24826) * Add Lily (#24813) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * License violations updates. (#24831) * Updated Licence Violations for Chosfox L75 (#24833) Co-authored-by: Joel Challis <git@zvecr.com> * Add Model-B keyboard (#24681) * Add Model-B keyboard * PR changes for Model-B * Update to OLED on Model-B * added license to pass lint check * update virtual eeprom for Model-B * eeconfig_read_kb() update on Model-B * cleanup changes for Model B * implementing Model B suggestions * Fix missing wait.h include in Dip Switch Map (#24863) * [License Violation] add pressplayid (#24869) add pressplayid lic viol Co-authored-by: Xelus22 <> * [Keyboard] Add Support E8ghtyNeo (#24859) * Update support S6xty5 * Delete chconf.h * Update manufacturer, community layout for hhkb * Update layout * fix row index * Update tyson60s * Update community layout and layout name * Update remove rgb test mode * Update capslock led * Apply suggestions from code review Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Remove deprecated s6xty5 * handle init e8ghtyneo firmware * Update qk boot firmware * Update firmware e8ghtyNeo * Update matrix * update manufacture * Update copyright --------- Co-authored-by: Trần Thanh Sơn <son.tt1@teko.vn> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add keyboard clap_studio/flame60 (#24870) - Got the source code from the _Clap_Studio_ Discord server - Migrated the source code to `keyboard.json` format - Added more layouts for most common cases - Fixed errors in `keymaps/default/keymap.c` - Updated the picture with a real picture of the PCB, to avoid confusion * Reject keyboard.json next to info.json (#24882) * Bump vite from 5.2.14 to 5.4.12 in /builddefs/docsgen (#24852) * [OS Detection] Improve MacOS detection (#24708) * update readme * address breaking changes https://docs.qmk.fm/ChangeLog/20240225 --------- Signed-off-by: Stefan Kerkmann <karlk90@pm.me> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: QMK Bot <hello@qmk.fm> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Álvaro A. Volpato <alvaro.augusto.volpato@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: yiancar <yiangosyiangou@cytanet.com.cy> Co-authored-by: yiancar <yiancar@gmail.com> Co-authored-by: フィルターペーパー <76888457+filterpaper@users.noreply.github.com> Co-authored-by: azhizhinov <azhizhinov@mail.ru> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Victor <87155454+t4corun@users.noreply.github.com> Co-authored-by: Joe Scotto <8194147+joe-scotto@users.noreply.github.com> Co-authored-by: Woodrow Douglass <git@wdouglass.com> Co-authored-by: Sadek Baroudi <sadekbaroudi@gmail.com> Co-authored-by: Stefan Kerkmann <karlk90@pm.me> Co-authored-by: Pascal Getreuer <50221757+getreuer@users.noreply.github.com> Co-authored-by: Alabahuy <rezolutionrez@gmail.com> Co-authored-by: David Doan <daviddoan1995@gmail.com> Co-authored-by: jack <jack@pngu.org> Co-authored-by: Ramon Imbao <ramonimbao@gmail.com> Co-authored-by: Jan Bláha <blaha.j502@gmail.com> Co-authored-by: Danny <nooges@users.noreply.github.com> Co-authored-by: Daniel Weeks <29613475+xanimos@users.noreply.github.com> Co-authored-by: era <73109780+eerraa@users.noreply.github.com> Co-authored-by: Felix Jen <fjen@felixjen.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Guido Bartolucci <guido@bartolucci.org> Co-authored-by: Nikolai Grigoriev <2364632+ngrigoriev@users.noreply.github.com> Co-authored-by: David Hoelscher <infinityis@users.noreply.github.com> Co-authored-by: Thanh Son Tran <62438883+trnthsn@users.noreply.github.com> Co-authored-by: Trần Thanh Sơn <son.tt1@teko.vn> Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com> Co-authored-by: leyew <102467346+itsme-zeix@users.noreply.github.com> Co-authored-by: takashicompany <t@kashi.company> Co-authored-by: Michael Büchler <michael.buechler@posteo.net> Co-authored-by: Diego Andres Rabaioli <drabaioli@gmail.com> Co-authored-by: Bennett Balogh <88569963+AwesomeBalogh@users.noreply.github.com> Co-authored-by: Christian C. Berclaz <christian.berclaz@mac.com> Co-authored-by: HereVoLand <65162585+Vem-596@users.noreply.github.com> Co-authored-by: Eric N. Vander Weele <ericvw@gmail.com> Co-authored-by: Akshay <32840608+axshae@users.noreply.github.com> Co-authored-by: Danny Tan <23428162+zykrah@users.noreply.github.com> Co-authored-by: Amund Tenstad <github@amund.io> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Druah <54309603+Druah@users.noreply.github.com> Co-authored-by: Naoki Katahira <yuchi.kbd@gmail.com> Co-authored-by: russell-myers1 <124931768+russell-myers1@users.noreply.github.com> Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: HorrorTroll <sonicvipduc@gmail.com> Co-authored-by: Daniel <1767914+iamdanielv@users.noreply.github.com> Co-authored-by: Pascal Getreuer <getreuer@google.com> Co-authored-by: Nebuleon <2391500+Nebuleon@users.noreply.github.com> Co-authored-by: Stephen Onnen <stephen.onnen@gmail.com> Co-authored-by: Nibell <Nibell91@gmail.com> Co-authored-by: Sắn <59417802+MaiTheSan@users.noreply.github.com> Co-authored-by: suikagiken <115451678+suikagiken@users.noreply.github.com> Co-authored-by: Thomas Queste <tom@tomsquest.com> Co-authored-by: Josh Hinnebusch <joshhinnebusch@gmail.com> Co-authored-by: VeyPatch <126267034+VeyPatch@users.noreply.github.com> Co-authored-by: harvey-splitkb <126267034+harvey-splitkb@users.noreply.github.com> Co-authored-by: gtips <51393966+gtips@users.noreply.github.com> Co-authored-by: Vaarai <joshwolfcarius@gmail.com> Co-authored-by: Stephen Edwards <sje.txt@gmail.com> Co-authored-by: Stephen Edwards <stephenedwardsemail@gmail.com> Co-authored-by: GustawXYZ <129527844+GustawXYZ@users.noreply.github.com> Co-authored-by: Can Baytok <ctiomega.1@gmail.com> Co-authored-by: Can Baytok <baytok@dydocon.com> Co-authored-by: Marco Pelegrini <marcopelegrini@users.noreply.github.com> Co-authored-by: Marco Pelegrini <mpelegrini@microsoft.com> Co-authored-by: kbd0 <108237598+kbd0@users.noreply.github.com> Co-authored-by: Vino Rodrigues <366673+vinorodrigues@users.noreply.github.com> Co-authored-by: Andrew Kannan <andrew.kannan@gmail.com> Co-authored-by: Patrickemm <mathern19@gmail.com> Co-authored-by: Feags <41646528+Feags@users.noreply.github.com> Co-authored-by: nuess0r <nussgipfel@brain4free.org> Co-authored-by: Lostdotfish <davidharley@gmail.com> Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com> Co-authored-by: J <12501551+NBeing@users.noreply.github.com> Co-authored-by: Bertrand Le Roy <beleroy@microsoft.com> Co-authored-by: dztech <moyi4681@users.noreply.github.com> Co-authored-by: chalex <68408520+gaclee3b@users.noreply.github.com> Co-authored-by: chalex <alejandrelee+magbogbro@gmail.com> Co-authored-by: James Gzowski <flexyjerkov@gmail.com> Co-authored-by: chillKB <107592205+chillKB@users.noreply.github.com> Co-authored-by: Tocho Tochev <tochev@users.noreply.github.com> Co-authored-by: Philip <68480429+iliorik@users.noreply.github.com> Co-authored-by: skandiPC <slinkinfs@yandex.ru> Co-authored-by: iliorik-ph <140731596+iliorik-ph@users.noreply.github.com> Co-authored-by: Sylvain Huguet <sylvain@kasten.io> Co-authored-by: Leo Lou <louyuhong@gmail.com> Co-authored-by: Haim Gelfenbeyn <haim@g8n.me> Co-authored-by: Patrick Fan <124469718+lighteningAB@users.noreply.github.com> Co-authored-by: Rory Chatterton <rory@wayvz.io> Co-authored-by: Brian Hill <51302710+TrojanPinata@users.noreply.github.com> Co-authored-by: Mick Hohmann <gh@m69.im.net>

Fix rendering of keymap_config.no_gui within led_update_kb

3948ba0

github-actions bot added the keyboard label Oct 11, 2024

drashna approved these changes Oct 11, 2024

View reviewed changes

drashna requested a review from a team October 11, 2024 19:50

waffle87 approved these changes Oct 11, 2024

View reviewed changes

zvecr merged commit a10e7cc into qmk:develop Oct 11, 2024
3 checks passed

zvecr deleted the fix_led_no_gui branch October 11, 2024 23:06

ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

b8b1141

…4473)

smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

e2c6d74

…4473)

jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

8bd399b

…4473)

DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

2fa3d8c

…4473)

SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

199d3ed

…4473)

LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

2ac003f

…4473)

MichaelScofield45 pushed a commit to MichaelScofield45/qmk_firmware that referenced this pull request Jan 8, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

d27efae

…4473)

pashashocky pushed a commit to pashashocky/qmk that referenced this pull request Jan 17, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

bd1c9fd

…4473)

Rumadon pushed a commit to Rumadon/qmk_firmware that referenced this pull request Jan 31, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

0e52d96

…4473)

MaximumP pushed a commit to MaximumP/qmk_firmware that referenced this pull request Feb 1, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

4789f9b

…4473)

alinelena pushed a commit to alinelena/qmk_firmware that referenced this pull request Feb 3, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

4fabdcc

…4473)

artlugovoy pushed a commit to artlugovoy/qmk_firmware that referenced this pull request Feb 16, 2025

Fix rendering of keymap_config.no_gui within led_update_kb (qmk#2…

7456cdb

…4473)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix rendering of `keymap_config.no_gui` within `led_update_kb` #24473

Fix rendering of `keymap_config.no_gui` within `led_update_kb` #24473

zvecr commented Oct 11, 2024 •

edited

Loading

Fix rendering of keymap_config.no_gui within led_update_kb #24473

Fix rendering of keymap_config.no_gui within led_update_kb #24473

Conversation

zvecr commented Oct 11, 2024 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Fix rendering of `keymap_config.no_gui` within `led_update_kb` #24473

Fix rendering of `keymap_config.no_gui` within `led_update_kb` #24473

zvecr commented Oct 11, 2024 •

edited

Loading