Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new keyboard ThumbsUp! v9 with a default keymap #23800

Merged
merged 21 commits into from
Oct 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ae05383
Added a cleaned-up set of files for ThumbsUp! v9.
ak66666 May 26, 2024
1535d21
Renamed the keymap for v9 as default
ak66666 May 26, 2024
1a4db31
Update keyboards/thumbsup/keymaps/default/keymap.c
ak66666 May 28, 2024
4bb076e
Update keyboards/thumbsup/keymaps/default/keymap.c
ak66666 May 28, 2024
b023dbd
Update keyboards/thumbsup/keymaps/default/keymap.c
ak66666 May 28, 2024
d525cdf
Update keyboards/thumbsup/keymaps/default/keymap.c
ak66666 May 28, 2024
172a9b3
Update keyboards/thumbsup/keymaps/default/keymap.c
ak66666 May 28, 2024
233538e
Update keyboards/thumbsup/rev9_promicro_4x12/info.json
ak66666 May 28, 2024
71e737e
Update keyboards/thumbsup/rev9_promicro_4x12/readme.md
ak66666 May 28, 2024
a139c55
Update keyboards/thumbsup/rev9_promicro_4x12/readme.md
ak66666 May 28, 2024
5d64881
Update keyboards/thumbsup/rev9_promicro_4x12/rules.mk
ak66666 May 28, 2024
4b5318a
Update keyboards/thumbsup/rev9_promicro_4x12/info.json
ak66666 May 28, 2024
613bb3b
Apply suggestions from code review
ak66666 May 28, 2024
a4beac2
Delete keyboards/thumbsup/keymaps/default/readme.md as per review rec…
ak66666 May 28, 2024
637daa9
v9: Fixed the layout name in keymap.c file.
ak66666 May 28, 2024
c813b63
Merge branch 'qmk:master' into thumbsup_20240523_pr
ak66666 May 29, 2024
3dfd500
v9: PR recommendatios applied - rules.mk file removed, info.json rena…
ak66666 May 29, 2024
d7cb44f
v9: PR recommendatios applied - rules.mk file removed, info.json rena…
ak66666 May 29, 2024
1a7dee8
v9: Fixed the copyright header modified by mistake.
ak66666 May 29, 2024
4ec8592
v9: Fixed the tri-layer switch as per the review recommendation.
ak66666 May 30, 2024
1711c34
v9: Fixed the copyright header modified by mistake.
ak66666 May 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
v9: PR recommendatios applied - rules.mk file removed, info.json rena…
…med to keyboard.json.
  • Loading branch information
ak66666 committed May 29, 2024
commit d7cb44f8f9514681456d5538187cb7da43d3ff41
48 changes: 13 additions & 35 deletions keyboards/thumbsup/keymaps/default/keymap.c
ak66666 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* Copyright 2022
/* Copyright 2022
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
Expand All @@ -19,18 +19,16 @@

// Defines names for use in layer keycodes and the keymap
enum layer_names {
// The first four layers are used for the tri-layer controls, so their order is important.
_QWERTY,
_CURSORLEFT,
_CURSORRGHT,
_NUMBERS,
_NUMPAD,
_EXTRARIGHT
};

// Aliases for this command to make the thumb keys work as LOWER/RAISE on hold and as space on hit.
#define CURSORRGHT LT(_CURSORRGHT,KC_SPC)
#define CURSORLEFT LT(_CURSORLEFT,KC_SPC)
//#define CURSORRGHT LT(_CURSORRGHT,KC_SPC)
//#define CURSORLEFT LT(_CURSORLEFT,KC_SPC)

const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {

Expand All @@ -57,11 +55,10 @@ Single hit: | | |Space | |Space | | |
KC_ESC, KC_Q, KC_W, KC_E, KC_R, KC_T, KC_Y, KC_U, KC_I, KC_O, KC_P, KC_BSPC,
LT(_EXTRARIGHT,KC_TAB), KC_A, KC_S, KC_D, KC_F, KC_G, KC_H, KC_J, KC_K, KC_L, KC_SCLN, KC_PENT,
KC_LCTL, KC_Z, KC_X, KC_C, KC_V, KC_B, KC_N, KC_M, KC_COMM, KC_DOT, KC_SLSH, KC_RCTL,
KC_SPC, KC_LGUI, KC_LALT, KC_LSFT, CURSORLEFT, CURSORRGHT, KC_RSFT, KC_RALT, KC_APP, KC_SPC
KC_SPC, KC_LGUI, KC_LALT, KC_LSFT, LT(_CURSORLEFT,KC_SPC), LT(_CURSORRGHT,KC_SPC), KC_RSFT, KC_RALT, KC_APP, KC_SPC
),



/*

Layers below are used on top of QWERTY layer defined above.
Expand Down Expand Up @@ -124,7 +121,7 @@ without separate thumbcluster.
* |------+------+------+------+------+------+------|------+------+------+------+------|
* | | xxx |MsBtRt|MsBtMi|MsBtLe| PgDn | xxx | Cut | Copy | Paste| xxx | |
* `------+------+------+------+------+------+------+------+------+------+------+------.
* | | | | X | | | | |
* | | | | X | | | | |
* `-------------------------------------------------------'
*/
[_CURSORLEFT] = LAYOUT(
Expand All @@ -141,7 +138,7 @@ without separate thumbcluster.
* | | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 0 |BackSp|
* |------+------+------+------+------+------|------+------+------+------+------+------|
* | | F1 | F2 | F3 | F4 | F5 | F6 | F7 | F8 | F9 | F10| Enter|
h * |------+------+------+------+------+-------------+------+------+------+------+------|
* |------+------+------+------+------+-------------+------+------+------+------+------|
* | | F11 | F12 | LAlt |LShift| LAlt | RAlt |RShift| , | . | / | |
* `------+------+------+------+------+------+------+------+------+------+------+------.
* | | | | | | | | |
Expand All @@ -163,39 +160,20 @@ h * |------+------+------+------+------+-------------+------+------+------+-----
key turning
this layer on
* |------+------+------+------+------+------|------+------+------+------+------+------|
* | | | |NumPad| | | | | [ | ] | \ | |
* | | | |NumPad|Qwerty| | | | [ | ] | \ | |
* `------+------+------+------+------+------+------+------+------+------+------+------.
* | | | | | | | | |
* `-------------------------------------------------------'
*/
[_EXTRARIGHT] = LAYOUT(
_______, KC_BRK, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_GRV, KC_EQL, KC_LPRN, KC_RPRN, KC_MINS, _______,
_______, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_PSCR, XXXXXXX, XXXXXXX, XXXXXXX, KC_QUOT, _______,
_______, XXXXXXX, XXXXXXX, TG(_NUMPAD), XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_LBRC, KC_RBRC, KC_BSLS, _______,
_______, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_LBRC, KC_RBRC, KC_BSLS, _______,
_______, _______, _______, _______, _______, _______, _______, _______, _______, _______
),

/* The right side turned into a numpad, set as default layer.
*
* ,-----------------------------------------||-----------------------------------------.
* | Esc | | | | | || / | 7 | 8 | 9 | - |BackSp|
* |------+------+------+------+------+------||------|------+------+------+------+------|
* | | | | | | || * | 4 | 5 | 6 | + |Enter |
Hold:
Extra-Rt
* |------+------+------+------+------+------||-------------+------+------+------+------|
* | Ctrl | | | | | || , | 1 | 2 | 3 | . | Ctrl |
* `------+------+------+------+------+------||------+------+------+------+------+------.
| GUI | Alt | | || | | 0 | . |
+------+------+ | || | +------+------+
Hold: | LSft |CursLt||CursRt| RSft |
Single hit: | |Space ||Space | |
+------+------||------+------+
*/
[_NUMPAD] = LAYOUT(
KC_ESC, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_KP_SLASH, KC_7, KC_8, KC_9, KC_KP_MINUS, KC_BSPC,
LT(_EXTRARIGHT,KC_TAB), XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_PAST, KC_4, KC_5, KC_6, KC_KP_PLUS, KC_PENT,
KC_LCTL, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, XXXXXXX, KC_COMM, KC_1, KC_2, KC_3, KC_DOT, KC_RCTL,
KC_SPC, KC_LGUI, KC_LALT, KC_LSFT, CURSORLEFT, CURSORRGHT, KC_RSFT, KC_0, KC_DOT, KC_SPC
)
};

layer_state_t layer_state_set_user(layer_state_t state) {
return update_tri_layer_state(state, _CURSORLEFT, _CURSORRGHT, _NUMBERS);
}

Loading