Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Checklist: explain wireless requirements. #23584

Merged
merged 3 commits into from
Apr 23, 2024
Merged

PR Checklist: explain wireless requirements. #23584

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9b82f3
Explain wireless requirements.
tzarc Apr 22, 2024
f5c72ac
Words.
tzarc Apr 22, 2024
b2dda1c
Words.
tzarc Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Words.
  • Loading branch information
@tzarc
tzarc committed Apr 23, 2024
commit b2dda1cefe08cc13e8720ce29d60296a865c74da
4 changes: 2 additions & 2 deletions docs/pr_checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard
- Code that needs to be used by multiple boards is a candidate for core code changes, and should be separated out.

Wireless-capable boards:
- Given license abuse from vendors, QMK does not accept any vendor PRs for wireless- or Bluetooth-capable keyboards without wireless and/or Bluetooth code.
- Historically, vendors have done this in bad faith in order to get downstream VIA compatibility
- Given license abuse from vendors, QMK does not accept any vendor PRs for wireless- or Bluetooth-capable keyboards without wireless and/or Bluetooth code
- Historically, vendors have done this in bad faith in order to attain downstream VIA compatibility with no intention of releasing wireless sources
- QMK's license, the GPL2+, requires full source disclosure for any distributed binary -- including full sources for any keyboard shipped by vendors containing QMK and/or firmware-side VIA code
- If a vendor's wireless-capable keyboard PR submission is lacking wireless capability, then the PR will be left on-hold and unmergeable until wireless bindings are provided
- If a vendor's wireless-capable keyboard is merged into QMK before it's known that the board is wireless, then all existing and future PRs from the same vendor will be put on hold until wireless bindings for the offending keyboard are provided
Expand Down
Loading