Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Refactor Helix #22643

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

[Keyboard] Refactor Helix #22643

wants to merge 3 commits into from

Conversation

waffle87
Copy link
Member

Description

  • Removes legacy code such as define's
  • Removes unnecessary and complicated makefiles
  • Adds keyboard level code that is used across revisions (keycodes and OLED behaviour)
  • Formatting on lots of files

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 11, 2023
@dunk2k
Copy link
Contributor

dunk2k commented Dec 11, 2023

I do like a good optimisation 😊

Could I be a cheeky (so and so) and ask for the following amendments:

  1. image URL in keyboards/helix/readme.md have the added h before .jpg?
  2. glcdfont.c is missing licence information in header, could it be added?

dunk2k
dunk2k suggested changes Dec 11, 2023
View reviewed changes
keyboards/helix/helix.c Show resolved Hide resolved
@github-actions github-actions bot added the dd Data Driven Changes label Dec 12, 2023
@waffle87 waffle87 marked this pull request as ready for review December 12, 2023 16:50
drashna
drashna requested changes Dec 13, 2023
View reviewed changes
keyboards/helix/helix.c Outdated Show resolved Hide resolved
keyboards/helix/helix.c Outdated Show resolved Hide resolved
keyboards/helix/pico/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/helix/pico/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/helix/pico/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/helix/pico/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/helix/rev2/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 23, 2023 21:29
@tzarc
Copy link
Member

tzarc commented Jan 9, 2024

Probably want @mtei to chime in on this one.

@tzarc tzarc requested a review from mtei January 9, 2024 11:15
@waffle87 waffle87 force-pushed the refactor/helix branch 2 times, most recently from 3037631 to d0bc72b Compare March 21, 2024 23:02
@waffle87 waffle87 force-pushed the refactor/helix branch 2 times, most recently from 5403347 to 5fcc6e8 Compare April 8, 2024 07:14
@waffle87 waffle87 closed this Jun 16, 2024
@waffle87 waffle87 deleted the refactor/helix branch June 16, 2024 06:38
@waffle87 waffle87 restored the refactor/helix branch June 16, 2024 17:07
@waffle87 waffle87 reopened this Jun 16, 2024
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 11, 2024
@waffle87 waffle87 added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Oct 13, 2024
waffle87 and others added 3 commits November 27, 2024 09:23
@waffle87
Refactor Helix
165e07e 
initial rev3_5rows

initial rev3_4rows

initial rev2

initial pico

keyboard level things

fixup

readme & remove aliases

some small improvements

drashna's suggestions

remove songs

align oled code with original
@waffle87
remove led_test keymap
8b8a47e
@waffle87
tidy keymaps and migrate to json
6252c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@drashna drashna drashna approved these changes

@mtei mtei Awaiting requested review from mtei

Assignees
No one assigned
Labels
awaiting review dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@waffle87 @dunk2k @tzarc @drashna