Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyboard LED driver configs #22638

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Update keyboard LED driver configs #22638

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
809c3d6
Update keyboard LED driver configs, AW20216S
fauxpark Dec 10, 2023
7a70992
Update keyboard LED driver configs, IS31FL3731
fauxpark Dec 10, 2023
3968da8
Update keyboard LED driver configs, IS31FL3733
fauxpark Dec 10, 2023
f1a95e0
Update keyboard LED driver configs, IS31FL3736
fauxpark Dec 10, 2023
8f160ff
Update keyboard LED driver configs, IS31FL3737
fauxpark Dec 10, 2023
c08faef
Update keyboard LED driver configs, IS31FL3741
fauxpark Dec 10, 2023
54d68cd
Update keyboard LED driver configs, SNLED27351
fauxpark Dec 10, 2023
c07d74b
Slight tweak
fauxpark Dec 10, 2023
eedf922
Use `WS2812_LED_COUNT` here instead
fauxpark Dec 10, 2023
3af280a
Fix up some typos in drivers
fauxpark Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix up some typos in drivers
  • Loading branch information
@fauxpark
fauxpark committed Dec 11, 2023
commit 3af280a34d251d6070190401035c1dbc3caba7f6
2 changes: 1 addition & 1 deletion drivers/led/issi/is31fl3218-simple.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "is31fl3218.h"
#include "is31fl3218-simple.h"
#include <string.h>
#include "i2c_master.h"

Expand Down
2 changes: 1 addition & 1 deletion drivers/led/issi/is31fl3733-simple.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
#endif

#ifndef IS31FL3733_CS_PULLDOWN
# define IS31FL3733_CSPULLDOWN IS31FL3733_PDR_0_OHM
# define IS31FL3733_CS_PULLDOWN IS31FL3733_PDR_0_OHM
#endif

#ifndef IS31FL3733_GLOBAL_CURRENT
Expand Down
2 changes: 1 addition & 1 deletion drivers/led/issi/is31fl3736.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ void is31fl3736_init(uint8_t addr) {
// Set up the mode and other settings, clear the PWM registers,
// then disable software shutdown.

is31fl3736_select_page(addr, IS31FL3736_REG_LED_CONTROL);
is31fl3736_select_page(addr, IS31FL3736_COMMAND_LED_CONTROL);

// Turn off all LEDs.
for (int i = 0; i < IS31FL3736_LED_CONTROL_REGISTER_COUNT; i++) {
Expand Down
3 changes: 2 additions & 1 deletion drivers/led/issi/is31fl3741-simple.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "wait.h"

#define IS31FL3741_PWM_REGISTER_COUNT 351
#define IS31FL3741_SCALING_REGISTER_COUNT 351

#ifndef IS31FL3741_I2C_TIMEOUT
# define IS31FL3741_I2C_TIMEOUT 100
Expand Down Expand Up @@ -64,7 +65,7 @@ uint8_t g_pwm_buffer[IS31FL3741_DRIVER_COUNT][IS31FL3741_PWM_REGISTER_COUNT];
bool g_pwm_buffer_update_required[IS31FL3741_DRIVER_COUNT] = {false};
bool g_scaling_registers_update_required[IS31FL3741_DRIVER_COUNT] = {false};

uint8_t g_scaling_registers[IS31FL3741_DRIVER_COUNT][IS31FL3741_PWM_REGISTER_COUNT];
uint8_t g_scaling_registers[IS31FL3741_DRIVER_COUNT][IS31FL3741_SCALING_REGISTER_COUNT];

void is31fl3741_write_register(uint8_t addr, uint8_t reg, uint8_t data) {
i2c_transfer_buffer[0] = reg;
Expand Down
3 changes: 2 additions & 1 deletion drivers/led/issi/is31fl3741.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include "wait.h"

#define IS31FL3741_PWM_REGISTER_COUNT 351
#define IS31FL3741_SCALING_REGISTER_COUNT 351

#ifndef IS31FL3741_I2C_TIMEOUT
# define IS31FL3741_I2C_TIMEOUT 100
Expand Down Expand Up @@ -64,7 +65,7 @@ uint8_t g_pwm_buffer[IS31FL3741_DRIVER_COUNT][IS31FL3741_PWM_REGISTER_COUNT];
bool g_pwm_buffer_update_required[IS31FL3741_DRIVER_COUNT] = {false};
bool g_scaling_registers_update_required[IS31FL3741_DRIVER_COUNT] = {false};

uint8_t g_scaling_registers[IS31FL3741_DRIVER_COUNT][IS31FL3741_PWM_REGISTER_COUNT];
uint8_t g_scaling_registers[IS31FL3741_DRIVER_COUNT][IS31FL3741_SCALING_REGISTER_COUNT];

void is31fl3741_write_register(uint8_t addr, uint8_t reg, uint8_t data) {
i2c_transfer_buffer[0] = reg;
Expand Down