Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model f labs f62 #21193

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

matthew-wolf-n4mtt
Copy link

New Keyboard Model F Labs F62

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 9, 2023
@zvecr zvecr added the pr_checklist_pending Needs changes as per the PR checklist label Jun 9, 2023
@matthew-wolf-n4mtt
Copy link
Author

What is the next step for this PR?
Is something I need to do?

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I swear I hit the submit, but apparently didn't...

keyboards/model_f_labs/f62/info.json Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/keymaps/via/config.h Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/readme.md Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/config.h Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/readme.md Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/rules.mk Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/wcass.c Outdated Show resolved Hide resolved
keyboards/model_f_labs/xwhatsit_util_comm.c Show resolved Hide resolved
@matthew-wolf-n4mtt
Copy link
Author

I think I have taken care of everything but two of the issues.

  1. config.h for the VIA keymap.
  • There are some statements in the file that are required by the custom code for the xwhatis code. Does the config.h file have to be removed?
  1. Using the keyboard file name. This can not change due to the way the utility problem uses the string to support multiple versions of the xwhatis controller installed in a large number of original IBM keyboards.

@matthew-wolf-n4mtt
Copy link
Author

I think I have taken care of everything.

keyboards/model_f_labs/f62/wcass/config.h Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/rules.mk Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/rules.mk Outdated Show resolved Hide resolved
@matthew-wolf-n4mtt
Copy link
Author

The config.h and rules.mk for wcass have been updated.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if you need to disable bootmagic, you should add this somewhere:

void bootmagic_lite(void) {}

This will disable bootmagic, even if it is enabled.

keyboards/model_f_labs/f62/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/config.h Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/wcass.h Outdated Show resolved Hide resolved
@matthew-wolf-n4mtt
Copy link
Author

What is the next thing that needs to be done?

@matthew-wolf-n4mtt
Copy link
Author

What is the next thing I need to do?

@matthew-wolf-n4mtt
Copy link
Author

I updated the readme over a month ago. What is the next thing needs to happen?

@matthew-wolf-n4mtt
Copy link
Author

I want to have this pull request accepted before the one year anniversary of it being opened.

@Wim4rk
Copy link

Wim4rk commented Jun 12, 2024

Hi,
The new model f keyboards really need to get QMK support running again. It hasn't since 18.10 or so. The merging of this PR would also make it easy to start working on f77 and other versions.
Please consider merging this PR.

@matthew-wolf-n4mtt
Copy link
Author

Hi, The new model f keyboards really need to get QMK support running again. It hasn't since 18.10 or so. The merging of this PR would also make it easy to start working on f77 and other versions. Please consider merging this PR.

I have have a PR for the F77 that is dependent on this PR to being approved.

Copy link

github-actions bot commented Aug 3, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 3, 2024
@matthew-wolf-n4mtt
Copy link
Author

Updated the VIA keymap to disable bootmagic.

@matthew-wolf-n4mtt matthew-wolf-n4mtt marked this pull request as draft August 7, 2024 03:26
@matthew-wolf-n4mtt matthew-wolf-n4mtt marked this pull request as ready for review August 7, 2024 03:26
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 8, 2024
keyboards/model_f_labs/f62/rules.mk Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/wcass/info.json Outdated Show resolved Hide resolved
keyboards/model_f_labs/f62/keymaps/via/keymap.c Outdated Show resolved Hide resolved
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 25, 2024
@matthew-wolf-n4mtt
Copy link
Author

We are waiting on the second approval of the pull request.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants