Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print error message when there are no row pins and no col pins #20104

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Don't print error message when there are no row pins and no col pins #20104

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c715fe
Don't print error message when there are no row pins and no col pins
purdeaandrei Mar 12, 2023
30c65a3
Update lib/python/qmk/info.py
zvecr Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Don't print error message when there are no row pins and no col pins 
This error message could be triggered for example if MATRIX_IO_DELAY is
configured in config.h, but the matrix is a custom one. The custom matrix
can still call back to existing delay functions that make use of the
MATRIX_IO_DELAY macro. In this case 'matrix_pins' in info_data will be true,
but there will be no 'direct' 'cols' or 'rows' in info_data['matrix_pins'],
and without this commit it would trigger an invalid error.
  • Loading branch information
@purdeaandrei
purdeaandrei committed Mar 12, 2023
commit 2c715fe45b6ecebf955b185ac7232938a6d2f4b3
2 changes: 2 additions & 0 deletions lib/python/qmk/info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,8 @@ def _check_matrix(info_data):
elif 'cols' in info_data['matrix_pins'] and 'rows' in info_data['matrix_pins']:
col_count = len(info_data['matrix_pins']['cols'])
row_count = len(info_data['matrix_pins']['rows'])
elif 'cols' not in info_data['matrix_pins'] and 'rows' not in info_data['matrix_pins']:
return

if col_count != actual_col_count and col_count != (actual_col_count / 2):
# FIXME: once we can we should detect if split is enabled to do the actual_col_count/2 check.
Expand Down