Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call eeprom_driver_erase in eeconfig_init_quantum #18567

Closed
wants to merge 1 commit into from
Closed

Only call eeprom_driver_erase in eeconfig_init_quantum #18567

wants to merge 1 commit into from

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Oct 2, 2022

Description

With the eeconfig being disabled, a eeconfig init is going to be performed on next boot anyway.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 2, 2022
@daskygit daskygit requested a review from tzarc October 2, 2022 17:24
@drashna drashna requested a review from a team October 2, 2022 20:30
@daskygit daskygit marked this pull request as draft October 2, 2022 20:51
@tzarc
Copy link
Member

tzarc commented Oct 3, 2022

For tracking purposes, was marked as draft due to generally sitting in the same area as #18332.

@daskygit
Copy link
Member Author

with #18332 being merged I'll close this

@daskygit daskygit closed this Jul 27, 2024
@daskygit daskygit deleted the fix/eeprom_driver_erase_dupe branch July 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc Awaiting requested review from tzarc

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @tzarc @drashna