Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy keycode use from command #18002

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Remove legacy keycode use from command #18002

merged 1 commit into from
Aug 12, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Aug 12, 2022 •
edited
Loading

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Aug 12, 2022
@zvecr zvecr requested a review from a team August 12, 2022 00:27
@zvecr zvecr added the bug label Aug 12, 2022
@zvecr zvecr merged commit 7e7387c into qmk:master Aug 12, 2022
@zvecr zvecr deleted the feature/command_legacy_keycode branch August 12, 2022 02:03
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@zvecr @imhoffman
Remove legacy keycode use from command (qmk#18002)
8dea685
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@zvecr @nolanseaton
Remove legacy keycode use from command (qmk#18002)
e1f3236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @drashna @fauxpark