KP Republic BM60HSRGB_EC QMK Configurator and readme touch-up #17541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- apply friendly formatting - adjust layout data to convey encoder rotation actions in QMK Configurator - specify rev1 in `keyboard_name` - update `maintainer` value - remove `meta` key
- adjust layout data to convey encoder rotation actions in QMK Configurator - specify rev2 in `keyboard_name` - update `maintainer` value
- correct Hardware Availability links (previously linked to wrong product page) - Markdown formatting update for `rev2/readme.md`
Previously listed maintainer has never committed to this codebase.
drashna
approved these changes
Jul 2, 2022
fauxpark
approved these changes
Jul 2, 2022
schattenbrot
pushed a commit
to schattenbrot/qmk_firmware
that referenced
this pull request
Aug 2, 2022
nolanseaton
pushed a commit
to nolanseaton/qmk_firmware
that referenced
this pull request
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Issues Fixed or Closed by This PR
QMK Configurator updates
keyboard_namemaintainervaluemetakeyBefore (rev1 shown):
After:
Readme updates
Change listed maintainer
Previously listed maintainer hasn't ever committed to this codebase... so I changed it.
cc @peepeetee (new keyboard maintainer)
Types of Changes
Checklist