Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct QMK Configurator layout data for Kin80 #17526

Merged
merged 3 commits into from
Jul 2, 2022

Conversation

noroadsleft
Copy link
Member

Description / Issues Fixed or Closed by This PR

Fixes misleading key assignments in the thumb clusters in QMK Configurator.

Before:
image
After:
image

cc @DmNosachev (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

The previous `LAYOUT_all` data was not visually consistent to that of `LAYOUT`, so I copied the `LAYOUT` tree and then added JSON objects for the keys that are present in only `LAYOUT_all`.
@fauxpark fauxpark merged commit 9b8ae05 into qmk:master Jul 2, 2022
casuanoob pushed a commit to casuanoob/qmk_firmware that referenced this pull request Jul 2, 2022
@noroadsleft noroadsleft deleted the cf/kin80 branch July 2, 2022 21:49
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants