-
-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MacroCat Keyboard #17480
Conversation
Co-authored-by: Joel Challis <git@zvecr.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyboards/macrocat/keymaps/default/rules.mk
should be deleted and not an empty file
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Thanks. Deleted. |
Hi @zvecr, I can't find how to mark the change requested as resolved, but I've already deleted that file. Can this PR get merged? |
PRs need 2 approvals before they can be merged. Opening and closing new PRs is only going to make the process take longer. |
Thanks for your explanation. Could you re-review the PR to clear the "Changes requested" alert? I can't find any other way to mark the requested change as resolved. I'm afraid that the alert will mislead other reviewers. |
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Description
Add support for MacroCat Keyboard
Types of Changes
Issues Fixed or Closed by This PR
Checklist