Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MacroCat Keyboard #17480

Merged
merged 17 commits into from
Jul 3, 2022
Merged

Add support for MacroCat Keyboard #17480

merged 17 commits into from
Jul 3, 2022

Conversation

starcatmeow
Copy link

Description

Add support for MacroCat Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/macrocat/config.h Outdated Show resolved Hide resolved
keyboards/macrocat/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/macrocat/macrocat.h Outdated Show resolved Hide resolved
keyboards/macrocat/rules.mk Outdated Show resolved Hide resolved
keyboards/macrocat/info.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Jun 26, 2022
keyboards/macrocat/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/macrocat/keymaps/oled/rules.mk Outdated Show resolved Hide resolved
keyboards/macrocat/macrocat.c Show resolved Hide resolved
keyboards/macrocat/macrocat.c Show resolved Hide resolved
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboards/macrocat/keymaps/default/rules.mk should be deleted and not an empty file

keyboards/macrocat/keymaps/via/rules.mk Outdated Show resolved Hide resolved
starcatmeow and others added 3 commits June 26, 2022 23:38
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@starcatmeow
Copy link
Author

keyboards/macrocat/keymaps/default/rules.mk should be deleted and not an empty file

Thanks. Deleted.

@starcatmeow starcatmeow requested a review from zvecr June 27, 2022 05:28
@zvecr zvecr reopened this Jun 28, 2022
@starcatmeow
Copy link
Author

Hi @zvecr, I can't find how to mark the change requested as resolved, but I've already deleted that file. Can this PR get merged?

@zvecr
Copy link
Member

zvecr commented Jun 28, 2022

Pull Request reviews are something that is done in our free time. We are not paid nor compensated for the time we spend reviewing, as it is a labor of love. As such, this means that it can take time for us to get to your Pull Request. Things like family, or life can get in the way of us getting to PRs, and burnout is a serious consideration. The QMK firmware repository averages 200 PRs opened and 200 PRs merged every month, so please have patience.

PRs need 2 approvals before they can be merged. Opening and closing new PRs is only going to make the process take longer.

@starcatmeow
Copy link
Author

Pull Request reviews are something that is done in our free time. We are not paid nor compensated for the time we spend reviewing, as it is a labor of love. As such, this means that it can take time for us to get to your Pull Request. Things like family, or life can get in the way of us getting to PRs, and burnout is a serious consideration. The QMK firmware repository averages 200 PRs opened and 200 PRs merged every month, so please have patience.

PRs need 2 approvals before they can be merged. Opening and closing new PRs is only going to make the process take longer.

Thanks for your explanation. Could you re-review the PR to clear the "Changes requested" alert? I can't find any other way to mark the requested change as resolved. I'm afraid that the alert will mislead other reviewers.

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
@zvecr zvecr merged commit 168a631 into qmk:master Jul 3, 2022
schattenbrot pushed a commit to schattenbrot/qmk_firmware that referenced this pull request Aug 2, 2022
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants