Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor XAP cli code to be more flexible and clean. I am not 100% on all the change, namely because I wasn't always able to confirm the magic numbers used in the code.
Also fixes a few bugs:
qmk xap listen
cli
forces the use of an action (SeeCliAction
)Potential problem: I tried to enforce LSB/MSB byte order to be correct everywhere, but unsure how well it will play out on Windows, where I think the
hex()
command might behave differently?Note: The
xap dump
command didn't work for me before my changes, so I did the best I could to keep the behaviour same sameTypes of Changes
Issues Fixed or Closed by This PR
N/A
Checklist