-
-
Notifications
You must be signed in to change notification settings - Fork 40.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tap hold confs away from keyboard-level files #14789
base: develop
Are you sure you want to change the base?
Move tap hold confs away from keyboard-level files #14789
Conversation
This moves tap hold configuration settings like IGNORE_MOD_TAP_INTERRUPT away from keyboard-level files and into the config.h files of the default and via (it if exists) keymaps. `#define TAP_TERM x` is ignored.
@@ -0,0 +1,3 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a license header and an include guard.
Same with the rest of the config.h files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whose name should I put in the license header though? The keyboard maker's? Mine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If unsure, then just QMK
is fine.
Thank you for your contribution! |
I'm currently busy with uni exams but I will get back to this, this is not stale. |
Will be in draft until #15741 gets merged. |
Description
This moves tap hold configuration settings like IGNORE_MOD_TAP_INTERRUPT
away from keyboard-level files and into the config.h files of the
default and via (it if exists) keymaps.
#define TAP_TERM x
is ignored, but I can make a follow-up commit to move it away from keyboard-level files too.The motivation for this PR is the following rule in the documentation on keyboard PRs:
Personally speaking, the fact that Dactyl Manuform enables PERMISSIVE_HOLD by default tripped me up because I couldn't understand why my keyboard was acting in a PERMISSIVE_HOLD manner, and thus causing modifier misfires, despite not having enabled it in my keymap
config.h
.Types of Changes
Issues Fixed or Closed by This PR
Checklist