Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up builds after #8591 #13900

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Fix up builds after #8591 #13900

merged 1 commit into from
Aug 5, 2021

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Aug 5, 2021

Description

As per the title. Need to remove anavi/macropad2 due to size constraints after merging #8591.
Disabled one of the RGB animations for helix/pico/sc to free up a handful of bytes and get it building, too.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc added the bug label Aug 5, 2021
@tzarc tzarc requested a review from a team August 5, 2021 23:48
@tzarc tzarc merged commit 0dafd83 into qmk:develop Aug 5, 2021
@tzarc tzarc deleted the fixup-builds-after-8591 branch August 6, 2021 00:02
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants