Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DP60 layout macro renames #13811

Merged
merged 4 commits into from
Jul 31, 2021
Merged

DP60 layout macro renames #13811

merged 4 commits into from
Jul 31, 2021

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_60_wkl to LAYOUT_60_ansi_tsangan_split_rshift
  • rename LAYOUT_60_wkl_split_bs to LAYOUT_60_tsangan_hhkb
  • remove key_count instances from info.json

cc @yulei (keyboard maintainer)

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team July 31, 2021 03:06
@zvecr zvecr merged commit 954806c into qmk:master Jul 31, 2021
@noroadsleft noroadsleft deleted the cf/dp60 branch July 31, 2021 18:10
CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this pull request Aug 8, 2021
@noroadsleft
DP60 layout macro renames (qmk#13811)
93dc9d4 
* info.json: apply human-friendly formatting

* rename LAYOUT_60_wkl to LAYOUT_60_ansi_tsangan_split_rshift

* rename LAYOUT_60_wkl_split_bs to LAYOUT_60_tsangan_hhkb

* info.json: remove `key_count` keys
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this pull request Aug 28, 2021
@noroadsleft
DP60 layout macro renames (qmk#13811)
b27506d 
* info.json: apply human-friendly formatting

* rename LAYOUT_60_wkl to LAYOUT_60_ansi_tsangan_split_rshift

* rename LAYOUT_60_wkl_split_bs to LAYOUT_60_tsangan_hhkb

* info.json: remove `key_count` keys
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@noroadsleft @nhongooi
DP60 layout macro renames (qmk#13811)
0e92d09 
* info.json: apply human-friendly formatting

* rename LAYOUT_60_wkl to LAYOUT_60_ansi_tsangan_split_rshift

* rename LAYOUT_60_wkl_split_bs to LAYOUT_60_tsangan_hhkb

* info.json: remove `key_count` keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr