Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update endgame keymap to work with suspend changes #13805

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Update endgame keymap to work with suspend changes #13805

merged 1 commit into from
Jul 31, 2021

Conversation

Slashbunny
Copy link

Description

Updates the Massdrop CTRL keyboard endgame keymap to work after the changes to USB suspend in #12697

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Slashbunny
Update endgame keymap to work with suspend changes
166aea2 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
@drashna drashna requested a review from a team July 31, 2021 00:18
@zvecr
Copy link
Member

zvecr commented Jul 31, 2021

Tagging @ash0x0 as the keymap author. Might have to go via the develop cycle if they dont approve.

@ash0x0
Copy link
Contributor

ash0x0 commented Jul 31, 2021

Thanks @Slashbunny

@zvecr zvecr merged commit 3f5482b into qmk:master Jul 31, 2021
@zvecr
Copy link
Member

zvecr commented Jul 31, 2021

Thanks!

CharlesSchimmel pushed a commit to CharlesSchimmel/qmk_firmware that referenced this pull request Aug 8, 2021
@Slashbunny
Update endgame keymap to work with suspend changes (qmk#13805)
c5144cd 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
VictorIsaacChavezEscamilla pushed a commit to VictorIsaacChavezEscamilla/qmk_firmware that referenced this pull request Aug 28, 2021
@Slashbunny
Update endgame keymap to work with suspend changes (qmk#13805)
415b138 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
nhongooi pushed a commit to nhongooi/qmk_firmware that referenced this pull request Dec 5, 2021
@Slashbunny @nhongooi
Update endgame keymap to work with suspend changes (qmk#13805)
917e954 
Updates the Massdrop CTRL keyboard engame keymap to work after the
changes to USB suspend in qmk#12697

Fixes qmk#13782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@ash0x0 ash0x0 ash0x0 approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Massdrop CTRL Endgame - Build Error 'undefined reference to g_suspend_state'
5 participants
@Slashbunny @zvecr @ash0x0 @drashna @fauxpark