Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved OpenRGB protctol for RGB Matrix keyboards #13036

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1db98bf
Implement the OpenRGB protocol
Kasper24 Apr 13, 2021
004c753
temp
Kasper24 Apr 13, 2021
c08b266
temp
Kasper24 May 7, 2021
f56ba7f
Add total leds to device info response
jath03 May 9, 2021
6fa6760
Removed extra initialization information
jath03 May 11, 2021
2911d12
bump openrgb protocol version
jath03 May 27, 2021
2c04b03
cleanup
Kasper24 May 28, 2021
57dc86c
Fix key labels
Kasper24 May 28, 2021
2efbc36
Fix error checks
Kasper24 May 28, 2021
4799064
Use KC_NO (=0) instead of 255 in OPENRGB_SWITCH_MATRIX_TO_PHYSICAL_PO…
Kasper24 May 28, 2021
883ee8f
Update Drop CTRL OPENRGB_SWITCH_MATRIX_TO_PHYSICAL_POS_MAP for the ne…
Kasper24 May 28, 2021
eff2561
wasn't meant to be comitted
Kasper24 May 28, 2021
884daa3
Fix typo
Kasper24 May 28, 2021
6c85c8c
Fix more issues with the key labels
Kasper24 May 29, 2021
eea35ac
Formatting
Kasper24 May 29, 2021
f9ca4ec
Remove unnecessary define
Kasper24 May 29, 2021
a6c5507
Send failure command at one before the last byte
Kasper24 May 29, 2021
5c84016
Combine QMK_RGBMATRIX_GET_DIRECT_MODE_LED_COLOR call into QMK_RGBMATR…
Kasper24 May 29, 2021
7d6f0ec
Fix OpenRGB keycode lookup when LEDs are out of order in matrix
CalcProgrammer1 May 29, 2021
4a0c5d4
Remove the manual keycode map lookup for the CTRL
Kasper24 May 29, 2021
1fa631c
Use the QMK version for the OpenRGB version string
Kasper24 May 30, 2021
e6631f6
Formatting
Kasper24 May 30, 2021
26aa5e0
Send OPENRGB_SUCCESS at the correct byte index
Kasper24 May 30, 2021
fe00b01
Add support for new RGB Matrix animations
Kasper24 May 30, 2021
57ccfa9
Cleaner
Kasper24 Jun 1, 2021
a2e0edd
Changes requested by Drashna Jaelre <drashna@live.com>
Kasper24 Jun 12, 2021
f455435
Update procotol version as the mode order was changed
Kasper24 Jun 29, 2021
d97c6b5
Merge each 8 GetLEDInfo HID calls into one single call
Kasper24 Jul 7, 2021
9bb71bf
Merge all IsEnabledMode HID calls into 1 single call
Kasper24 Jul 7, 2021
3f910b7
Update protocol version
Kasper24 Jul 7, 2021
fdc6886
Make direct mode blue by default as some keyboard lockup if it's set …
Kasper24 Aug 4, 2021
0589a4c
Add support for saving to eeprom
Kasper24 Sep 6, 2021
96ceb2d
Rebased
Kasper24 Nov 19, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Send failure command at one before the last byte
  • Loading branch information
Kasper24 committed Nov 19, 2021
commit a6c5507c6e412e291ab5c7e96b90f18f6ecc2412
6 changes: 3 additions & 3 deletions quantum/openrgb.c
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ void openrgb_get_direct_mode_led_color(uint8_t *data) {
raw_hid_buffer[0] = OPENRGB_GET_DIRECT_MODE_LED_COLOR;

if (led >= DRIVER_LED_TOTAL) {
raw_hid_buffer[1] = OPENRGB_FAILURE;
raw_hid_buffer[RAW_EPSIZE - 2] = OPENRGB_FAILURE;
return;
}

Expand All @@ -318,7 +318,7 @@ void openrgb_set_mode(uint8_t *data) {
raw_hid_buffer[0] = OPENRGB_SET_MODE;

if (h > 255 || s > 255 || v > 255 || mode >= RGB_MATRIX_EFFECT_MAX || speed > 255) {
raw_hid_buffer[1] = OPENRGB_FAILURE;
raw_hid_buffer[RAW_EPSIZE - 2] = OPENRGB_FAILURE;
return;
}

Expand All @@ -337,7 +337,7 @@ void openrgb_direct_mode_set_single_led(uint8_t *data) {
raw_hid_buffer[0] = OPENRGB_DIRECT_MODE_SET_SINGLE_LED;

if (led >= DRIVER_LED_TOTAL || r > 255 || g > 255 || b > 255) {
raw_hid_buffer[1] = OPENRGB_FAILURE;
raw_hid_buffer[RAW_EPSIZE - 2] = OPENRGB_FAILURE;
return;
}

Expand Down