Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matrix: wait for row signal to go HIGH for every row #12945

Merged
merged 1 commit into from
May 19, 2021

Commits on May 19, 2021

  1. matrix: wait for row signal to go HIGH for every row

    I noticed this discrepancy (last row of the matrix treated differently than the
    others) when optimizing the input latency of my keyboard controller, see also
    https://michael.stapelberg.ch/posts/2021-05-08-keyboard-input-latency-qmk-kinesis/
    
    Before this commit, when tuning the delays I noticed ghost key presses when
    pressing the F2 key, which is on the last row of the keyboard matrix: the
    dead_grave key, which is on the first row of the keyboard matrix, would be
    incorrectly detected as pressed.
    
    After this commit, all keyboard matrix rows are interpreted correctly.
    
    I suspect that my setup is more susceptible to this nuance than others because I
    use GPIO_INPUT_PIN_DELAY=0 and hence don’t have another delay that might mask
    the problem.
    stapelberg committed May 19, 2021
    Configuration menu
    Copy the full SHA
    986cb0a View commit details
    Browse the repository at this point in the history