Skip to content

[DOC] Missing LED_MATRIX_INDICATOR_SET_VALUE #24890

Open
@iamdanielv

Description

Issue Description

The documentation for LED Matrix references "a special macro to help make this easier to use: LED_MATRIX_INDICATOR_SET_VALUE(i, v)."

But I can't find that macro in the current main branch of the code.

It was pretty trivial to write:

#define LED_MATRIX_INDICATOR_SET_VALUE(i, v) \
    if (i >= led_min && i < led_max) {       \
        led_matrix_set_value(i, v);          \
    }

It is confusing to have the documents reference code that doesn't exist.

I suggest to either :

  • remove the mention of the macro, or
  • put the macro back in the led_matrix.h file

I can create a PR with the changes if it's ok with the maintainers.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions