Skip to content

fix: unify plugins enable and qlty init behaviour for package_file and filters and more #2334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: unify plugins enable and qlty init behaviour for package_file and filters and more #2334

wants to merge 2 commits into from

Conversation

marschattha
Copy link
Member

Fixes #2319

@Copilot Copilot AI review requested due to automatic review settings August 20, 2025 00:24
@marschattha marschattha mentioned this pull request Aug 20, 2025
Closed
@marschattha marschattha changed the title Allow plugins enable to use qlty init behaviour for package_file and filters and more feat: allow plugins enable to use qlty init behaviour for package_file and filters and more Aug 20, 2025
@marschattha marschattha changed the title feat: allow plugins enable to use qlty init behaviour for package_file and filters and more fix: unify plugins enable and qlty init behaviour for package_file and filters and more Aug 20, 2025
@marschattha marschattha requested a review from brynary August 20, 2025 00:28
@qltysh qltysh
Copy link
Contributor

qltysh bot commented Aug 20, 2025

2 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 18): enable_plugin 1
qlty Structure Deeply nested control flow (level = 5) 1

qltysh[bot]
qltysh bot reviewed Aug 20, 2025
View reviewed changes
@qltysh qltysh
Copy link
Contributor

qltysh bot commented Aug 20, 2025

Diff Coverage for ubuntu-latest: The code coverage on the diff in this pull request is 93.5%.

Total Coverage for ubuntu-latest: This PR will increase coverage by 0.04%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-cli/src/commands/init.rs 0.4
qlty-cli/src/commands/plugins/enable.rs 3.8
qlty-cli/src/initializer/scanner.rs -0.1
qlty-cli/src/initializer/scanner/package_file.rs -0.5
qlty-coverage/src/ci/github.rs -0.3 √
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh qltysh
Copy link
Contributor

qltysh bot commented Aug 20, 2025

Diff Coverage for macos-15: The code coverage on the diff in this pull request is 93.5%.

Total Coverage for macos-15: This PR will increase coverage by 0.04%.

File Coverage Changes
Path File Coverage Δ Indirect
qlty-cli/src/commands/init.rs 0.4
qlty-cli/src/commands/plugins/enable.rs 3.8
qlty-cli/src/initializer/scanner.rs -0.1
qlty-cli/src/initializer/scanner/package_file.rs -0.5
qlty-coverage/src/ci/github.rs -0.3 √
🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

qltysh[bot]
qltysh bot reviewed Aug 20, 2025
View reviewed changes
qlty-cli/src/initializer/scanner.rs
Comment on lines +145 to +150
if enable_plugins.contains_key(&plugin_initializer.plugin_name) {
self.plugins_to_activate
.entry(plugin_initializer.plugin_name.to_owned())
.or_default()
.drivers
.insert(driver_initializer.key(), driver_initializer.clone_box());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 5) [qlty:nested-control-flow]

Copilot
Copilot AI reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qltysh qltysh[bot] qltysh[bot] left review comments

Copilot code review Copilot Copilot left review comments

@brynary brynary Awaiting requested review from brynary

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: When enabling plugin through qlty plugins enable, package file and filters are not checked
1 participant
@marschattha