fix: bump release type by dependent if deps.release is inherit#100
Merged
antongolub merged 6 commits intoqiwi:masterfrom Jul 28, 2024
Merged
fix: bump release type by dependent if deps.release is inherit#100antongolub merged 6 commits intoqiwi:masterfrom
antongolub merged 6 commits intoqiwi:masterfrom
Conversation
antongolub
requested changes
May 16, 2024
Member
|
Hey, @gavmck, Could you add a test for the fix? |
Contributor
Author
Sure thing, I'll drop some in shortly |
Contributor
Author
|
@antongolub Sorry, I know this has taken ages! |
antongolub
approved these changes
Jul 24, 2024
Member
antongolub
left a comment
antongolub
left a comment
There was a problem hiding this comment.
Seems good. Thanks for the contribution.
We will land this asap.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2024
## [7.1.2](v7.1.1...v7.1.2) (2024-07-28) ### Bug Fixes * bump release type by dependent if deps.release is inherit ([#100](#100)) ([d44f324](d44f324))
Member
|
🎉 This PR is included in version 7.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When
deps.releaseis set toinherit, but a package has changes, it overwrites the release type from the dependent package, even if the release type was greater (patch < minor < major).This updates the
resolveRelesaseTypefunction so that if a dependent package has a larger version bump anddeps.releaseis set to inherit, we'll take the inherited release type instead of the lesser local package one.Test scenario: I had a major version bump in one of my packages that all other packages are dependent on and the dependent packages were only doing a minor update because they had local changes.