Issue #367 - Migration from QasmSimulator to qiskit_aer's AerSimulator #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grace-harper this PR is ready for review 👍 |
robotastray
changed the title
robotastray
changed the title
|
Hello @grace-harper the errors are related to a bug I identified and described in issue #380. I do not think is related to the work I did on issue #367. |
* remove execute import from faultsampler.py * remove execute imports from faultenumerator.py * remove execute import from test_heavy_hex_decoder.py * remove execute import from test_repetitionmatcher.py * remove execute import from test_circuitmatcher.py
grace-harper
added a commit
that referenced
this pull request
Oct 2, 2023
#378) * Migration from QasmSimulator to qiskit_aer's AerSimulator * eliminate execute from imports (#1) * remove execute import from faultsampler.py * remove execute imports from faultenumerator.py * remove execute import from test_heavy_hex_decoder.py * remove execute import from test_repetitionmatcher.py * remove execute import from test_circuitmatcher.py --------- Co-authored-by: grace-harper <119029214+grace-harper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses issue #367 by implementing changes across various files in the codebase. The changes involve the migration from
qiskit.Aertoqiskit_aer, replacement ofQasmSimulatorwithAerSimulator, and the introduction ofPadDynamicalDecoupling. Additionally, the PR requires the use ofALAPScheduleAnalysiswithin thePassManagerDetails and comments:
The following files have been modified as part of this PR:
src/qiskit_qec/analysis/faultenumerator.pysrc/qiskit_qec/analysis/faultsampler.pysrc/qiskit_qec/circuits/repetition_code.pytest/code_circuits/test_rep_codes.pytest/heavy_hex_codes/test_heavy_hex_decoder.pytest/matching/test_circuitmatcher.pytest/matching/test_repetitionmatcher.pyKey Changes:
qiskit.Aertoqiskit_aer,QasmSimulatortoAerSimulatorPadDynamicalDecoupling, which requires the use ofALAPScheduleAnalysisinPassManager.