Change self._num_features in ValueError message (backport #981)
#984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 56bbed0)
mergify
bot
requested review from
Benjamin-Symons,
OkuyanBoga,
adekusar-drl,
edoaltamura,
oscar-wallis,
smens and
woodsp-ibm
as code owners
Collaborator
|
Note that #985 must be fixed to merge this PR. |
Pull Request Test Coverage Report for Build 17612554236Details
💛 - Coveralls |
edoaltamura
approved these changes
Sep 10, 2025
edoaltamura
added a commit
that referenced
this pull request
Sep 10, 2025
) * Correct output shape in `EstimatorQNN` tutorial (#982) (cherry picked from commit 7b57913) * Change `self._num_features` in ValueError message (backport #981) (#984) (#988) * Correct `self._num_features` in ValueError (#981) (cherry picked from commit 56bbed0) * Update copyright in `base_kernel.py` --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> --------- Co-authored-by: Edoardo Altamura <38359901+edoaltamura@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For a custom feature map with all parameters marked as trainable, one can run into
self._num_features = 0(becausefeature_map.num_parameters == _num_training_parameters), which then triggers_validate_inputsto detectx_vec.shape[1] != self._num_features; however, the ValueError mistakenly reportsself._feature_map.num_parametersinstead ofself._num_features, making the real problem hard to debug. This update improves the error message to beself._num_features. Unittests do not need updating.Details and comments
Fixes #932
This is an automatic backport of pull request #981 done by [Mergify](https://mergify.com).