Attempt to remedy random CI failures #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodsp-ibm
requested review from
adekusar-drl,
smens,
edoaltamura,
oscar-wallis,
OkuyanBoga and
Benjamin-Symons
as code owners
Pull Request Test Coverage Report for Build 15052613295Details
💛 - Coveralls |
edoaltamura
approved these changes
May 16, 2025
There was a problem hiding this comment.
Let's see how the CI runs go over the next few days with the seed fixed. I don't remember it making a big difference when I tried in the past, but I had fixed the seed in .run() rather.
It'd be great if a new noiseless default for GenericBackendV2 isn't needed (see #903 (comment)).
edoaltamura
added
the
stable backport potential
mergify bot
pushed a commit
that referenced
this pull request
May 22, 2025
(cherry picked from commit ff55d2c)
edoaltamura
pushed a commit
that referenced
this pull request
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#903 lists CI failures that are seen randomly to occur here. I tried running the tests locally a few times and had a couple of failures. After changing the code I did not see any failures. Trying again though on the unaltered code I could not seem to get any failures again.
As such I am not sure the extent, if any, that this will remedy the situation. I added the simuator seed, via options, just in case one of the others, which was not set before, was what ends up getting used so hopefully the extra seeds help. The tests still pass with them set and so they seem to do no harm as such even if they end up not really being used. But lets see how things go. I did not mark this PR to close the random error one i.e. #903 but rather figured, if this seems ok and gets merged, to see how CI goes over time and if we see no re-occurence then close. If I see any random failure as this goes through CI then I think I will close it as clearly it would not be remedying things effectively. (Update: it seems to have gone through CI and passed everything ok, with no random failure, so I guess time will tell how effective this update really can be).
Details and comments
Note: EstimatorOptions does have a seed_estimator and I had initially set that too. But I removed it as it generated a warning when running the tests that it was not used with the local simulator.