-
Notifications
You must be signed in to change notification settings - Fork 368
Added Entanglement Concentration Dataset for 3 and 4 qubits for Benchmarking Binary Classifiers #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Classification dataset for 3 and 4 qubits - Pre-trained weights courtesy to https://github.com/LSchatzki/NTangled_Datasets - The CE values claimed in the above repository had a mismatch for 8 qubits, hence we've left other number of qubits for future development - Make html breaks for some reason. Need to fix in upcoming commits Co-Authored-By: Nishant Vasan <69106567+rockywick@users.noreply.github.com> Co-Authored-By: rogue-infinity <116993419+rogue-infinity@users.noreply.github.com>
Oh the init file seems to have gotten missed. I'll recommit |
Not sure why the 3.9 tests are passing but the 3.11 and 3.12 ones are failing. And it seems like the routine is raising errors majorly only on files I've left untouched. Any inputs of what might be happening? |
If you look at Actions tab at the top of the page i.e. here https://github.com/qiskit-community/qiskit-machine-learning/actions you will see Machine Learning Tests that are Scheduled. These are the same tests but are run nightly so any changes in dependents that may cause problems/failures etc are caught. The scheduled tests have been failing for a while and the main branch code needs updating in some way (maybe pinning to an earlier dependent or changing code to suit etc) so things pass again. With that done, and then merged with the code in your PR, it would then only be changes done by your PR that could cause failures - but with the base (i.e. main) failing its not. |
The CI issues have been fixed so I updated the branch (via the update button that was here) so any issues now would be just down to this PR - unless it has a random failure for which there is an issue #903 around that, |
Pull Request Test Coverage Report for Build 15622602924Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is nearly ready. I'd suggest not using npy files though, because decoding the binaries might require a specific version of Numpy, which will likely change in the future. Since the files are relatively small, we could convert the arrays in the npys to json or txt files.
training_size: int, | ||
test_size: int, | ||
n: int, | ||
mode: str = "easy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My take, instead of suppressing the warning about too many positional args, would be to add *,
after the n
parameter which would allow the first 3 arguments to be positional but require the following, which do have defaults so they do not need to be provided, be provided when doing so as keyword arguments only.
Summary
Classification dataset for 3 and 4 qubits based on the concentration of entanglement (CE) in Quantum States. Two pre-trained circuits are used to generate states of a given amount of CE. Users can use this dataset to benchmark their binary classification pipelines.
Pre-trained weights courtesy to https://github.com/LSchatzki/NTangled_Datasets. The CE values claimed in the above repository had a mismatch for 8 qubits, hence we've left other number of qubits for future development
I've verified mypy, spell, lint and black. For some reason, make html breaks the other modules. Need some help with resolving that
Details and comments